Closed Bug 577695 Opened 10 years ago Closed 9 years ago

Filter out the Nounclass strings in compare-locales

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: p.franc, Assigned: p.franc)

Details

Attachments

(1 file)

In calendar/chrome/calendar/calendar-event-dialog.properties localizer can add extra strings to support the noun classes in their localization. These strings are reported by compare-locales script as obsolete. They should be filter out by filter.py script.
From the bug report it is not clear to me if this is a bug in compare-locals or not. What is the purpose of the attached file?
That file would go to calendar/locales/filter.py.

It would make all excessive entries for the nounclass stuff to be ignored in compare-locales.
Comment on attachment 456585 [details]
Example of working script.py

good stuff, thanks for the script!
Attachment #456585 - Flags: review+
I've decided to turn around the conditions a bit so its easier to add exceptions in the future.
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c3d6867fa36f>
-> FIXED
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/5785f2394bb3>
Target Milestone: Trunk → 1.0b4
yac, gotta reopen.

Due to the way that the filter.py is activated, you have to have the

import re

inside the function, otherwise you get a "global name re not found" exception, which compare-locales silently eats.

(Should I warn about that in some way? Guess so)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ah, sorry about that. I haven't seen python imports inside functions, but Pavel correctly put it there. Sorry for moving it out! Why can't it be global, btw?
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2d7862781f8c>
-> FIXED
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: 1.0b4 → Trunk
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/9728004561c9>
Target Milestone: Trunk → 1.0b4
cs and ru locales are green -  https://l10n-stage-sj.mozilla.org/dashboard/?tree=calendar10x
Status: RESOLVED → VERIFIED
Today's beta uplift is not transplanting this cset (http://hg.mozilla.org/releases/comm-beta/rev/728a63b46d38 ) to the new head, and this bug does not indicate its on aurora or what, so please verify this is correct where you need it.
Assignee: nobody → p.franc
You need to log in before you can comment on or make changes to this bug.