577695 - Filter out the Nounclass strings in compare-locales

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Pavel Franc - Mozilla.cz]

Attachment: Example of working script.py

In calendar/chrome/calendar/calendar-event-dialog.properties localizer can add extra strings to support the noun classes in their localization. These strings are reported by compare-locales script as obsolete. They should be filter out by filter.py script.

Comment 1

[Stefan Sitter [:ssitter]]

From the bug report it is not clear to me if this is a bug in compare-locals or not. What is the purpose of the attached file?

Comment 2

[Axel Hecht [:Pike]]

That file would go to calendar/locales/filter.py.

It would make all excessive entries for the nounclass stuff to be ignored in compare-locales.

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 456585 [details]
Example of working script.py

good stuff, thanks for the script!

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

I've decided to turn around the conditions a bit so its easier to add exceptions in the future.

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c3d6867fa36f>
-> FIXED

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/5785f2394bb3>

Comment 7

[Axel Hecht [:Pike]]

yac, gotta reopen.

Due to the way that the filter.py is activated, you have to have the

import re

inside the function, otherwise you get a "global name re not found" exception, which compare-locales silently eats.

(Should I warn about that in some way? Guess so)

Comment 8

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Ah, sorry about that. I haven't seen python imports inside functions, but Pavel correctly put it there. Sorry for moving it out! Why can't it be global, btw?

Comment 9

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2d7862781f8c>
-> FIXED

Comment 10

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/9728004561c9>

Comment 11

[Pavel Franc - Mozilla.cz]

cs and ru locales are green -  https://l10n-stage-sj.mozilla.org/dashboard/?tree=calendar10x

Comment 12

[Justin Wood (:Callek)]

Today's beta uplift is not transplanting this cset (http://hg.mozilla.org/releases/comm-beta/rev/728a63b46d38 ) to the new head, and this bug does not indicate its on aurora or what, so please verify this is correct where you need it.