577817 - One declaration rule violation in zlib used by Mozilla

Status: RESOLVED INVALID

(Core :: General, defect)

Description

[Jan Hubicka]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100506 SUSE/3.5.10-0.1.1 Firefox/3.5.10 GTB7.1
Build Identifier: 

modules/zlib/src/zlib.h contains weird hack 
> #if !defined(ZUTIL_H) && !defined(NO_DUMMY_DECL)
>     struct internal_state {int dummy;}; /* hack for buggy compilers */
> #endif

the following patch fixes it:

--- zlib.h.old  2010-07-10 15:41:05.000000000 +0200
+++ modules/zlib/src/zlib.h     2010-07-10 15:33:15.000000000 +0200
@@ -40,6 +40,7 @@
 #define ZLIB_VERSION "1.2.3"
 #define ZLIB_VERNUM 0x1230
 
+#define NO_DUMMY_DECL
 /*
      The 'zlib' compression library provides in-memory compression and
   decompression functions, including integrity checks of the uncompressed


Reproducible: Always

Comment 1

[Sylvestre Ledru [:Sylvestre]]

is it still relevant?

Comment 2

[BugBot [:suhaib / :marco]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Probably invalid