Closed Bug 577918 Opened 10 years ago Closed 9 years ago

mark DEBUG only variables as ifdef DEBUG in parser

Categories

(Core :: DOM: HTML Parser, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 1 obsolete file)

this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456745 - Flags: review?(mrbkap)
Comment on attachment 456745 [details] [diff] [review]
patch

There are more places we can use this (but they're covered up by manually expanded NS_DEBUG_ASSIGNs). We'll have to get those as we come to them.
Attachment #456745 - Flags: review?(mrbkap) → review+
brendan has insisted that we not add a macro, so this is "the way"
Attachment #456745 - Attachment is obsolete: true
Attachment #463514 - Flags: review+
Summary: use NS_DEBUG_ASSIGN for parser → mark DEBUG only variables as ifdef DEBUG in parser
Attachment #463514 - Flags: approval2.0?
Attachment #463514 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/04ec9b6ace68
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.