Closed Bug 577919 Opened 14 years ago Closed 13 years ago

mark DEBUG only variables as ifdef DEBUG in security

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 1 obsolete file)

using #ifdef DEBUG
1.70 KB, patch
KaiE
: review+
johnath
: approval2.0-
Details | Diff | Splinter Review 
this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → timeless
Status: NEW → ASSIGNED

        Attachment #456746 -
        Flags: review?(kaie)

    
    

    
  
Comment on attachment 456746 [details] [diff] [review]
patch

this patch is not ready for review, because the NS_DEBUG_ASSIGN does not yet exist and there's a debate in the base bug. I propose to postpone until there's progress.

        Attachment #456746 -
        Flags: review?(kaie) → review-

    
    

    
  


  
brendan has insisted that we not add a macro, so this is "the way"

        Attachment #456746 -
        Attachment is obsolete: true

        Attachment #463515 -
        Flags: review?(kaie)

    
  
Summary: use NS_DEBUG_ASSIGN for security → mark DEBUG only variables as ifdef DEBUG in security

    
    

    
  
Comment on attachment 463515 [details] [diff] [review]
using #ifdef DEBUG

If I understand correctly, you'll still get these warnings when compiling in debug mode.

So, I'm not sure how much value this change has.

But r=kaie

        Attachment #463515 -
        Flags: review?(kaie) → review+

    
    

    
  
in debug builds the variables are used by the assertions which follow the code.
OS: Mac OS X → Windows 7

    
  

        Attachment #463515 -
        Flags: approval2.0?

    
    

    
  
Comment on attachment 463515 [details] [diff] [review]
using #ifdef DEBUG

Righteous change, but unneeded in the 11th hour of gecko2.0 release.

        Attachment #463515 -
        Flags: approval2.0? → approval2.0-

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/df9528ef03a9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2

    
    

    
  
Can someone confirm if this is fixed?
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: