mark DEBUG only variables as ifdef DEBUG in security

RESOLVED FIXED in mozilla5

Status

Core Graveyard
Security: UI
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla5
x86
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.70 KB, patch
kaie
: review+
johnath
: approval2.0-
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
this is part of a crusade to get rid of compilation warnings
(Assignee)

Comment 1

7 years ago
Created attachment 456746 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456746 - Flags: review?(kaie)

Comment 2

7 years ago
Comment on attachment 456746 [details] [diff] [review]
patch

this patch is not ready for review, because the NS_DEBUG_ASSIGN does not yet exist and there's a debate in the base bug. I propose to postpone until there's progress.
Attachment #456746 - Flags: review?(kaie) → review-
(Assignee)

Comment 3

7 years ago
Created attachment 463515 [details] [diff] [review]
using #ifdef DEBUG

brendan has insisted that we not add a macro, so this is "the way"
Attachment #456746 - Attachment is obsolete: true
Attachment #463515 - Flags: review?(kaie)
(Assignee)

Updated

7 years ago
Summary: use NS_DEBUG_ASSIGN for security → mark DEBUG only variables as ifdef DEBUG in security

Comment 4

7 years ago
Comment on attachment 463515 [details] [diff] [review]
using #ifdef DEBUG

If I understand correctly, you'll still get these warnings when compiling in debug mode.

So, I'm not sure how much value this change has.

But r=kaie
Attachment #463515 - Flags: review?(kaie) → review+
(Assignee)

Comment 5

7 years ago
in debug builds the variables are used by the assertions which follow the code.
OS: Mac OS X → Windows 7
(Assignee)

Updated

7 years ago
Attachment #463515 - Flags: approval2.0?
Comment on attachment 463515 [details] [diff] [review]
using #ifdef DEBUG

Righteous change, but unneeded in the 11th hour of gecko2.0 release.
Attachment #463515 - Flags: approval2.0? → approval2.0-

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/df9528ef03a9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Can someone confirm if this is fixed?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.