577947 - TabCandy toolbarbutton lacks styling on Windows and Linux

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Steffen Wilberg]

The tabcandy toolbarbutton is a giant button consisting of the downalods, history, bookmarks, new tab and new window button images.

That's because there's no styling for it on winstripe and gnomestripe.

Comment 1

[Steffen Wilberg]

Attachment: patch

Copies the styling from pinstripe's browser.css to winstripe and gnomestripe.

Comment 2

[Steffen Wilberg]

See http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser/Toolbar-small.png for how the button looks like right now on Linux...

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #1)
> Created attachment 456763 [details] [diff] [review]
> patch
> 
> Copies the styling from pinstripe's browser.css to winstripe and gnomestripe.

Patch accepted.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #2)
> See
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser/Toolbar-small.png
> for how the button looks like right now on Linux...

Steffen, not sure if you meant for this bug to actually create Linux- and Win-appropriate styles as well. If not, feel free to close it.

Comment 5

[Steffen Wilberg]

> (In reply to comment #1)
> Patch accepted.
Thanks. Why don't you just set the review flag on the details page of the patch to "+"?

(In reply to comment #4)
> Steffen, not sure if you meant for this bug to actually create Linux- and
> Win-appropriate styles as well. If not, feel free to close it.
Comment 2 was just meant to be an illustration of the bug, instead of attaching a screenshot. This bug is not about changing the icon itself.

--> marking fixed.
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/e81604098ae6(In reply to comment #3)

Comment 6

[Aza Raskin [:aza]]

Thanks for the patch, Steffen!

Comment 7

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".