Closed Bug 577947 Opened 12 years ago Closed 12 years ago

TabCandy toolbarbutton lacks styling on Windows and Linux

Categories

(Firefox Graveyard :: Panorama, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file)

The tabcandy toolbarbutton is a giant button consisting of the downalods, history, bookmarks, new tab and new window button images.

That's because there's no styling for it on winstripe and gnomestripe.
Attached patch patchSplinter Review
Copies the styling from pinstripe's browser.css to winstripe and gnomestripe.
Attachment #456763 - Flags: review?(mitcho)
See http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser/Toolbar-small.png for how the button looks like right now on Linux...
(In reply to comment #1)
> Created attachment 456763 [details] [diff] [review]
> patch
> 
> Copies the styling from pinstripe's browser.css to winstripe and gnomestripe.

Patch accepted.
(In reply to comment #2)
> See
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser/Toolbar-small.png
> for how the button looks like right now on Linux...

Steffen, not sure if you meant for this bug to actually create Linux- and Win-appropriate styles as well. If not, feel free to close it.
> (In reply to comment #1)
> Patch accepted.
Thanks. Why don't you just set the review flag on the details page of the patch to "+"?

(In reply to comment #4)
> Steffen, not sure if you meant for this bug to actually create Linux- and
> Win-appropriate styles as well. If not, feel free to close it.
Comment 2 was just meant to be an illustration of the bug, instead of attaching a screenshot. This bug is not about changing the icon itself.

--> marking fixed.
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/e81604098ae6(In reply to comment #3)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #456763 - Flags: review?(mitcho)
Thanks for the patch, Steffen!
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.