Closed Bug 578013 Opened 14 years ago Closed 14 years ago

[meta] Toolbars in Javascript pop-ups aren't customizable

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 586234

People

(Reporter: rimas, Unassigned)

References

(Depends on 1 open bug, )

Details

Attachments

(1 file)

Attached image Windows screenshot
I don't like the way toolbars are handled in Pop-up windows. Namely:
1. any disabled toolbars cannot be re-enabled (on Windows and Linux), but are shown as enabled.
2. similarly, on Mac, the only way to re-enable those toolbars is to click twice the pill-shaped button on the far right of window title bar. That effectively hides all toolbars and then un-hides all that are enabled by default. Now that's a bug and a feature at the same time! :)
3. (Fx4) while middle clicking a link opens it in a new tab in the same pop-up window, the tab strip is invisible and can only be made visible on Mac (see 2.) This is a REGRESSION from Firefox 3.6 where the tabs become visible immediately.

STR: 
1. Open http://www.brusselsairport.be/en/flightinfo/departures/
2. Click on a link in "Track" column. A pop-up should open with only the Address Bar in the Navigation Toolbar.
3. Right click on the Navigation Toolbar and find the browser claiming that all the toolbars are actually still there, while they are not.
4. Middle click any of the links in a page. It opens in a new tab, but there is no way to go to that tab. Basically, there's no feedback to the middle click from the browser.
5. On Mac, click twice the Hide Toolbars button (on the far right of the window title). First it hides all toolbars that are shown, but clicking it for a second time makes ALL toolbars enabled in the browser re-appear.
6. On Win7, toggle the "Tabs on Top" box. This will change the way Navigation toolbar is shown (Aero glass vs. opaque panel). This also looks like a bug, because there are no tabs shown.

I suggest something smarter should be done about the pop-ups. Perhaps, special flag could be introduced for pop-ups and used by toolbars? I think the experience could be as follows:

1. Respective toolbars in pop-up windows should be hidden properly: they should be disabled in "unchecked" sense, so that it would be easier to get them back.
2. toggling toolbars using the button in OS X window title bar should do exactly that: toggle display of enabled toolbars. It should not change the amount, order or content of those toolbars.
3. tab strip should become visible whenever there's more than one tab.
4. state of "Tabs on Top" should not affect the way other toolbars are painted when the tab strip is actually not shown.

5. not sure about this, but perhaps clicking the Toggle Toolbars button on Mac OS should also affect the state of enabled toolbars? E.g., perhaps the View -> Toolbars menu should be disabled when the toolbars are toggled off?


I'm pretty much aware that this is more of a meta bug than a real one, but all the issues are weaved with each other, so it's not easy to separate. If anyone could help me with separating them and defining the right components for each of them, I'd be greatful.
Component: General → Toolbars
QA Contact: general → toolbars
I just reported Bug 578016 about Toggle Toolbars not affecting the state of View -> Toolbars menu.
Depends on: 578016
Concerning the Tab Usage in Popups, this is now handled in Bug 586234.
Concerning the Toolbar Stuff, I'd suggest filling another Bugreport.

IMHO the Toolbar-Customizations Dialog should just be disabled/removed in Popup-Windows since - as you noticed - it does not work.
The Location Bar as Chrome UI Item + the Content UI is sufficient, no?
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Blocks: 593869
No longer blocks: 593869
Depends on: 593869
(In reply to comment #2)
> Concerning the Toolbar Stuff, I'd suggest filling another Bugreport.

Bug 593869

> IMHO the Toolbar-Customizations Dialog should just be disabled/removed in
> Popup-Windows since - as you noticed - it does not work.

IMHO we should fix stuff that doesn't work quite as expected instead of removing it.
Summary: Toolbars in Javascript pop-ups aren't customizable → [meta] Toolbars in Javascript pop-ups aren't customizable
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: