578047 - More native look on Vista/Win7 for the aw-menulist

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Richard Marti (:Paenglab)]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; de-DE; rv:2.0b2pre) Gecko/20100712 Minefield/4.0b2pre
Build Identifier: 

This patch makes the aw-menulist more native looking than the old WinNT appearance.


Reproducible: Always

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Patch to change the appearance of aw-menulist

Is this okay with ui-rewiew @ clarkbw and review @ philringnalda?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Image showing the difference

Comment 3

[Ludovic Hirlimann [:Usul]]

Comment on attachment 456865 [details] [diff] [review]
Patch to change the appearance of aw-menulist

Philor is booked a lot these days carying over to Andreas.

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: unbitrotted patch

It seems that the patch had bitrotted for some reason, as I couldn't apply it cleanly on trunk. This one should work better.

Comment 5

[Andreas Nilsson (:andreasn)]

Comment on attachment 456865 [details] [diff] [review]
Patch to change the appearance of aw-menulist

Minus on this since I can't get it to apply cleanly. Mark thought it might be related to line endings being wrong.
Will give plus on the edit I did however.

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 457050 [details] [diff] [review]
unbitrotted patch

(not that this is just a edited version of Richards patch that avoids the bitrot)
Not sure if the child selector is really needed in this case, but I can't see it do any harm either, so r+ on this.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 456865 [details] [diff] [review]
Patch to change the appearance of aw-menulist

looks good

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 457050 [details] [diff] [review]
unbitrotted patch

oh, this is the right one now.  Thanks Richard!

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/b1f196e3f84b