578068 - Incorrect platform file is offered in EULA page for sandboxed add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

This was reported on the forum. This add-on has Windows and Mac files: https://addons.mozilla.org/en-US/firefox/addon/176735/. It also has an intermediate page where the EULA is displayed.

If you hover over the install button in the EULA page, the target looks right, pointing to the Mac file. But when you click on the button and get the warning popup, the install button points to the Windows file.

Comment 1

[Jeff Balogh (:jbalogh)]

Works for me.

Comment 2

[Justin Scott [:fligtar]]

If you'd like me to reproduce for you, stop by anytime. It still happens for me.

Comment 3

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> If you'd like me to reproduce for you, stop by anytime.

You have no idea how hard I am trying not to laugh.

Carry on! :)

Comment 4

[Jeff Balogh (:jbalogh)]

This could happen to any button with multiple files, such as https://addons.mozilla.org/en-US/firefox/addon/5579/versions/?page=1#version-1.11.5

http://github.com/jbalogh/zamboni/commits/dea2580

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I could reproduce the bug on prod, and can't on preview:

https://preview.addons.mozilla.org/en-US/firefox/addon/176735/eula/92504?src=addondetail

Comment 6

[Clement]

I've just tested it from a computer with Mac OSX with this addon https://addons.mozilla.org/fr/firefox/addon/176735/

And when I'm downloading it, the AMO platform is still giving me the windows version (1,7Mo) instead of the mac version (700Ko).

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

This fix is scheduled to be pushed live next Thursday.