578153 - Need test verifying that watchpoints trigger in JaegerMonkey-compiled code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

There should be a unit test that sets a watchpoint on some object's property, and then verifies that JaegerMonkey-compiled code does trigger that watchpoint.

It would be nice to have an API to ensure that a function gets JM-compiled.

Comment 1

[Andrew Drake [:adrake]]

See bug 579145 for API, beginning work on this now.

Comment 2

[Andrew Drake [:adrake]]

Attachment: Simple tests

This just tests if watchpoints can be set from JIT code, and if watchpoints can be hit from JIT code (both work). I can't really think of anything more specific to test than this until JM starts doing creepy things with property accesses. Any input?

Comment 3

[Andrew Drake [:adrake]]

I don't really think we need to commit these -- AFAICT adding a watch changes an object's shape, so even PIC'd accesses will correctly hit the watchpoint (and a failure to hit the watchpoint would indicate a more general problem with PICs). If a problem comes up later it would be more useful to have more targeted tests.