Closed Bug 578153 Opened 14 years ago Closed 14 years ago

Need test verifying that watchpoints trigger in JaegerMonkey-compiled code

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jimb, Assigned: adrake)

References

Details

Attachments

(1 file)

There should be a unit test that sets a watchpoint on some object's property, and then verifies that JaegerMonkey-compiled code does trigger that watchpoint.

It would be nice to have an API to ensure that a function gets JM-compiled.
Blocks: JaegerDebug
Depends on: 579145
Assignee: general → adrake
See bug 579145 for API, beginning work on this now.
Attached patch Simple testsSplinter Review
This just tests if watchpoints can be set from JIT code, and if watchpoints can be hit from JIT code (both work). I can't really think of anything more specific to test than this until JM starts doing creepy things with property accesses. Any input?
I don't really think we need to commit these -- AFAICT adding a watch changes an object's shape, so even PIC'd accesses will correctly hit the watchpoint (and a failure to hit the watchpoint would indicate a more general problem with PICs). If a problem comes up later it would be more useful to have more targeted tests.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: