578201 - Fix some tabs module doc nits

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

Just noticed this while helping someone in #jetpack:  The final code example in the tabs doc needs to be indented 4 spaces so Markdown knows it's code.  Also, we're using var in examples rather than let, since let is (still) Mozilla-specific.  And, updated onOpen to explain that the page has not loaded at that point.

Comment 1

[Dietrich Ayala (:dietrich)]

Comment on attachment 456954 [details] [diff] [review]
patch


> <api name="onOpen">
>-@property {object}
>-Fired when a new tab is opened.
>+@property {collection}
>+Fired when a new tab is opened. Note that at this point the page has not
>+finished loading, so not all properties of the `tab` object passed to listeners
>+will be available.  For example, `tab.location` will not be correct. Use
>+`onReady` or `onLoad` to be notfified when the page has loaded.

s/Note that//

typo: notfified

r=me otherwise, thanks!

Comment 2

[Drew Willcoxon :adw]

Thanks!

http://hg.mozilla.org/labs/jetpack-sdk/rev/34c42dbf24e7

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".