578258 - Calling votes.cgi with no arguments should either display the user's votes, or give a better error message if the extension is disabled

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

In Bugzilla 2.x and 3.x, accessing votes.cgi directly with no arguments displays all your votes. In Bugzilla 4.0, it throws this very unhelpful error message:

 "I could not figure out what you wanted to do."

Guess what? I wanted to see my votes! :-D

If the extension is enabled, it should display your votes. If the extension is disabled, it should explain that you cannot access your votes because this extension is disabled.

Comment 1

[Frédéric Buclin]

One more thing: if you pass the correct arguments but the extension is disabled, you get an even more confusing error message:

 "The requested format does not exist with a content type of html."

This is the generic error message when one template cannot be found with the correct extension (here: .html.tmpl).

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Max Kanat-Alexander]

Comment on attachment 457714 [details] [diff] [review]
patch, v1

This is a really great fix, thanks! :-)

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified votes.cgi
modified template/en/default/global/code-error.html.tmpl
Committed revision 7378.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified votes.cgi
modified template/en/default/global/code-error.html.tmpl
Committed revision 7330.