578267 - Fix a few minor UI issues with the new keyword autocomplete changes

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

This patch fixes two issues:
1) Too much extra space below and above the keywords <input>. This space isn't needed. Just get rid of it.
2) Keywords <input> on show_bug is too small compared to the other <input> fields.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 456997 [details] [diff] [review]
patch - v1

Hmm. No, don't use !important in production, shipping CSS. There are better ways to override the cascade, like #bugzilla-body.

Is this still an issue even though I updated the text-input CSS on 4.0 and trunk?

Comment 2

[Max Kanat-Alexander]

  I do agree that the padding should go away, though, and that's definitely not handled by the other bug even if the textbox size is.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #1)
> Hmm. No, don't use !important in production, shipping CSS. There are better
> ways to override the cascade, like #bugzilla-body.

We're already using it elsewhere in order to override the YUI code. What makes this one different?

(In reply to comment #1)
> Is this still an issue even though I updated the text-input CSS on 4.0 and
> trunk?

Issue #2 looks fixed, but issue #1 is still there.

Comment 4

[Max Kanat-Alexander]

(In reply to comment #3)
> We're already using it elsewhere in order to override the YUI code. What makes
> this one different?

  Oh wow, you're right. We should not be doing that.

  It's valid for us to be using !important in a few, rare places (like bz_default_hidden, which needs to always override everything, because it's a programmatic thing and not really a style thing), but most of those places should not be using it.

> Issue #2 looks fixed, but issue #1 is still there.

  Okay.

Comment 5

[Guy Pyrzak]

Attachment: v2

Comment 6

[Max Kanat-Alexander]

Comment on attachment 473737 [details] [diff] [review]
v2

It looks like all of this has already been done in other patches, now, other than removing padding-bottom on #keyword_container.

Comment 7

[Guy Pyrzak]

Attachment: v3

Comment 8

[Guy Pyrzak]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                                   
modified skins/standard/global.css
Committed revision 7509. 

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/                                     
modified skins/standard/global.css
Committed revision 7426.