Add comment to unused file svgBindings.xml to indicate why it's still in the tree

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Just stumbled across this file:
  layout/svg/base/src/resources/content/svgBindings.xml

It used to be used in svg.css as:
> a {
>   -moz-binding:url('chrome://global/content/svg/svgBindings.xml#a');            

but that went away in bug 267664:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/svg/base/src&command=DIFF_FRAMESET&file=svg.css&rev2=1.17&rev1=1.16

and now there are zero code references to this file, and only one other reference, in "jar.mn":
  http://mxr.mozilla.org/mozilla-central/search?string=svgBindings.xml

Pretty sure this can just be removed...
(Assignee)

Updated

8 years ago
Depends on: 267664
(Assignee)

Comment 1

8 years ago
Created attachment 457133 [details] [diff] [review]
fix: delete file [didn't end up using; see comment 3]

This patch removes the file and its mention in jar.mn.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Attachment #457133 - Flags: review?(jwatt)
Comment on attachment 457133 [details] [diff] [review]
fix: delete file [didn't end up using; see comment 3]

That file was actually being left deliberately because implementing bug 163068 will likely involve adding content to it. I guess it can be removed and we can add it back at that time. I'd also r+ a patch to just add a comment to that file saying why it's not been removed though. Either way.
Attachment #457133 - Flags: review?(jwatt) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> I'd also r+ a patch to just add a comment to that
> file saying why it's not been removed though. Either way.

Ok -- since its continued presence in the tree was deliberate, I went with your suggested alternative of adding a short explanatory comment to svgBindings.xml:
  http://hg.mozilla.org/mozilla-central/rev/41f7430df680
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Summary: Delete unused file: svgBindings.xml → Add comment to unused file svgBindings.xml to indicate why it's still in the tree
(Assignee)

Updated

8 years ago
Attachment #457133 - Attachment description: fix → fix: delete file [didn't end up using; see comment 3]
Depends on: 1319428
You need to log in before you can comment on or make changes to this bug.