578467 - xpinstall.whitelist.add prefs are not emptied when converted into permissions on startup with new profile

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ian Neal]

Steps to reproduce
1/ Move .mozilla/firefox profile out of the way
2/ Start trunk build of firefox
3/ Look at about:config

Expected Result
1/ Entries for xpinstall.whitelist.add should be user set with empty strings.

Actual Result
1/ Entries for xpinstall.whitelist.add show default with their default values.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Do we have documentation how this feature has to work in detail? I haven't used that preference so far. As what I can see we never obey those values. Even adding another value later doesn't add the domain to the whitelist.

Comment 2

[Dave Townsend [:mossop]]

This is a blocker as it means we will re-import permissions that users have removed. One line patch, should be simple if someone wants to take it.

Comment 3

[Ben Parr [:bparr]]

Attachment: Patch and Test

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 458929 [details] [diff] [review]
Patch and Test

Nice work.

Comment 5

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/dede7d7e4a5b

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100826 Minefield/4.0b5pre