578470 - Redirect popular 404s

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Jeff Balogh (:jbalogh)]

We're seeing lots of 404s on these urls:

/{extensions,themes}/{newest,updated,popular,rated,moreinfo.php}
/search/rss

Comment 1

[Justin Scott [:fligtar]]

We're getting tens of thousands of 404s on these a day. Can we bump this up?

Comment 2

[Wil Clouser [:clouserw]]

Where do you want them to go?

Comment 3

[Justin Scott [:fligtar]]

They should go to the appropriate browse pages.

/extensions/newest goes to the newest sort of extensions, etc.

This should match for all of them except moreinfo.php which should go to the add-on details page, as this is what the details page used to be called and apparently we lost that rewrite somewhere.

Comment 4

[Wil Clouser [:clouserw]]

So, to translate to zamboni:

newest => new
updated => updated
popular => popular
rated => ???

Can you give me a full URL for moreinfo.php and /search/rss?  I assume there are query params

Comment 5

[Justin Scott [:fligtar]]

newest -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=created
updated -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=updated
popular -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=popular
rated -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=rating

sample moreinfo.php url:
http://update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=220

Not sure about search rss.

Comment 6

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> newest -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=created
> updated -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=updated
> popular -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=popular
> rated -> https://addons.mozilla.org/en-US/firefox/extensions/?sort=rating
> 
> sample moreinfo.php url:
> http://update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=220
> 
> Not sure about search rss.

I found search: /en-US/firefox/search/rss/?q=test

moreinfo is crazy old.  I can't imagine anyone other than bots hitting that.  The rest of these are pretty easy, but that one will take a little code if you want to support it.

Comment 7

[Justin Scott [:fligtar]]

(In reply to comment #6)
> moreinfo is crazy old.  I can't imagine anyone other than bots hitting that. 
> The rest of these are pretty easy, but that one will take a little code if you
> want to support it.

Is it more complicated than rewriting moreinfo.php?application=(firefox|thunderbird|seamonkey|sunbird).*?id=(\w+) to /$1/addon/$2?

I think we used to do that.

Comment 8

[Justin Scott [:fligtar]]

and by \w I obviously meant \d

Comment 9

[Wil Clouser [:clouserw]]

I was thinking of keeping them out of apache, but whatever.  We'll need oremj around to do this then, and he's out till Thurs.

Comment 10

[Jeremy Orem [:oremj]]

Can we put these in .htaccess(http://svn.mozilla.org/addons/trunk/site/app/webroot/.htaccess) with the rest of the rewrites/redirects?

Comment 11

[Jeremy Orem [:oremj]]

I think we should keep these with the rest of the redirects. We'll have to do an svn up on remora and can move .htaccess over to zamboni when remora is completely gone.

Comment 12

[Wil Clouser [:clouserw]]

Attachment: redirects

I added some of the redirects that were handled by PHP code to the .htaccess.  The moreinfo.php one is already in the .htaccess so I don't know why it's not working - oremj?

We'll have to wait on zamboni search to get the RSS feed - the old URL isn't working for me even if I type it in manually.

Comment 13

[Wil Clouser [:clouserw]]

Alright, r72484.  I changed the moreinfo.php redirect so hopefully that works, but it should be checked on PAMO.

Comment 14

[krupa raj[:krupa]]

STR:
Load https://next.addons.mozilla.org/en-US/firefox/extensions/newest/ OR https://preview.addons.mozilla.org/en-US/firefox/extensions/newest/

I just get a 404. Reopening...

Comment 15

[Wil Clouser [:clouserw]]

oremj:  is there something else that needs to be done here?  see the commit in comment 13 to see the .htaccess

Comment 16

[Jeremy Orem [:oremj]]

Added moreinfo rewrite to vhost.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

1. http://update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=220 currently redirects to https://addons.mozilla.org/en-US/firefox/extensions/moreinfo.php/?application=firefox&version=1.0&os=Windows&id=220, which is a 404, but changing the host to be preview. doesn't work either.
2. https://preview.addons.mozilla.org/en-US/firefox/search/rss/?q=test is a 404
3. The URLs in comment 14 don't work either.

Reopening.

Comment 18

[Wil Clouser [:clouserw]]

(In reply to comment #17)
> 1.
> http://update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=220
> currently redirects to
> https://addons.mozilla.org/en-US/firefox/extensions/moreinfo.php/?application=firefox&version=1.0&os=Windows&id=220,
> which is a 404, but changing the host to be preview. doesn't work either.

I don't know anything about UMO's redirects, but this works fine on PAMO:

https://preview.addons.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=220

> 2. https://preview.addons.mozilla.org/en-US/firefox/search/rss/?q=test is a 404
I said in comment 12 the search RSS feed isn't going to happen in this bug.


> 3. The URLs in comment 14 don't work either.
This rewrite doesn't accept locales.  Use https://preview.addons.mozilla.org/firefox/extensions/newest/

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Shouldn't https://preview.addons.mozilla.org/seamonkey/extensions/newest redirect to https://preview.addons.mozilla.org/en-US/seamonkey/extensions/?sort=created?  Currently, it goes to https://preview.addons.mozilla.org/en-US/seamonkey/extensions/?sort=newest.

Comment 20

[Wil Clouser [:clouserw]]

We renamed those a while ago to be consistent across the site.  These don't redirect and I don't really care since these are old redirects.  If you do, please open a new bug so I can kick it into some far away milestone.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #20)
> We renamed those a while ago to be consistent across the site.  These don't
> redirect and I don't really care since these are old redirects.  If you do,
> please open a new bug so I can kick it into some far away milestone.

Well, what I didn't explicitly say, but is evident in the links, is that https://preview.addons.mozilla.org/en-US/seamonkey/extensions/?sort=newest is actually ?sort=popular ("Downloads" is selected).

But as you say, you don't care since they're old redirects.  So we basically only care that the redirects work for Firefox URLs and/or that the others don't 404, right?

Comment 22

[Wil Clouser [:clouserw]]

Right, these URLs were used as old in-product URLs and stuff.  So, only the exact URL needs to work and the other minor bits aren't a worry to me, since once they start clicking on the site it'll use new ones.

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

Per my understanding, https://preview.addons.mozilla.org/firefox/themes/?sort=newest should redirect to https://preview.addons.mozilla.org/en-US/firefox/themes/?sort=created; it's still going to https://preview.addons.mozilla.org/en-US/firefox/themes/?sort=popular, internally.

Comment 24

[Wil Clouser [:clouserw]]

(In reply to comment #23)
> Per my understanding,
> https://preview.addons.mozilla.org/firefox/themes/?sort=newest should redirect
> to https://preview.addons.mozilla.org/en-US/firefox/themes/?sort=created; it's
> still going to
> https://preview.addons.mozilla.org/en-US/firefox/themes/?sort=popular,
> internally.

That's true!