If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

MXR returns strange results for gfxTextRun::GetChar

NEW
Unassigned

Status

Webtools
MXR
--
major
7 years ago
6 years ago

People

(Reporter: Ehsan, Unassigned)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(URL)

It seems to be returning char keywords in files whose names include gfxTextRun...

Comment 1

7 years ago
http://mxr.mozilla.org/mozilla-central/ident?i=GetChar&tree=mozilla-central&filter=gfxTextRun&strict=1

the logic that's applied is perhaps a bit too fuzzy.

What it does is treats 'GetChar' as 'GetChar' or 'char' because in .js or .idl it could be 'GetChar' or 'char'. It should probably only apply that heuristic to .js/.idl/... instead of everything.
(In reply to comment #1)
> What it does is treats 'GetChar' as 'GetChar' or 'char' because in .js or .idl
> it could be 'GetChar' or 'char'. It should probably only apply that heuristic
> to .js/.idl/... instead of everything.

Yes, I guess that it makes sense for it to apply that logic only two files which use the literal names defined in the IDL.
I suppose this is the same bug:
http://mxr.mozilla.org/mozilla-central/ident?i=GetColCount
...
Defined as a variable in:
    editor/libeditor/html/nsTableEditor.cpp (View Hg log or Hg annotations)
        line 465 -- PRInt32 rowCount, colCount, rowIndex;
... and a lot of other lines I didn't want to see ...

Is anyone working on fixing MXR bugs these days?
Severity: normal → major
You need to log in before you can comment on or make changes to this bug.