578513 - cc_accessible and reporter_accessible should be is_cc_accessible and is_reporter_accessible in the WebServices

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Max Kanat-Alexander]

For compatibility with Gerv's BzAPI, and just for consistency across all our booleans, every boolean that the WebServices API accepts or returns should start with "is_" unless it would be totally nonsensical for it to do so.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This should make all the relevant functions and documentation consistent.

Comment 2

[Frédéric Buclin]

Comment on attachment 480379 [details] [diff] [review]
v1

>=== modified file 'Bugzilla/WebService/Bug.pm'

>-=item C<reporter_accessible>
>+=item C<is_creator_accessible>

IMO, this change is pretty weird. We never talk about bug *creator* anywhere in Bugzilla. We clearly use the "reporter" label everywhere else. This is non-sense to me.

Comment 3

[Frédéric Buclin]

Also, a bug creator can be seen as the one who breaks the code. The bug reporter is the one who finds the bug and report it to Bugzilla.

Comment 4

[Frédéric Buclin]

Comment on attachment 480379 [details] [diff] [review]
v1

Hum, I see that you use 'creator' in Bug.get() to get the reporter, so I will remove my r-. But this is IMO a bad choice.

Comment 5

[Max Kanat-Alexander]

LpSolit: See bug 574995 for the reasoning on "creator".

Comment 6

[Tiago Mello [:timello]]

Comment on attachment 480379 [details] [diff] [review]
v1

I'd go with the consistency here. If we are currently using 'creator', then 'creator' should be the choice.

Comment 7

[Max Kanat-Alexander]

Attachment: v2

There was minor bitrot on checkin, this is what got checked in.

Comment 8

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Bug.pm
modified Bugzilla/WebService/Bug.pm
Committed revision 7562.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/                         
modified Bugzilla/Bug.pm
modified Bugzilla/WebService/Bug.pm
Committed revision 7451.