578524 - web view of TM hg repository seems to be stuck

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Andreas Gal :gal]

kahoolawe:src gal$ hg push -r default
pushing to ssh://"[e-mail]"@hg.mozilla.org//tracemonkey
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: Trying to insert into pushlog.
remote: Please do not interrupt...
remote: Inserted into the pushlog db sucessfully.
kahoolawe:src gal$ hg pull
pulling from http://hg.mozilla.org/tracemonkey/
searching for changes
no changes found
kahoolawe:src gal$ hg export tip
# HG changeset patch
# User Andreas Gal <[e-mail]>
# Date 1279063365 25200
# Node ID cfdbd2d27b5fef97dc89733124ff906600612137
# Parent  49abcb57270a9c2da0256063212423698e14df2d
Compartments can get GCed while we allocate the first object inside of them (576722, r=mrbkap).

diff --git a/js/src/jsgc.cpp b/js/src/jsgc.cpp
--- a/js/src/jsgc.cpp
+++ b/js/src/jsgc.cpp
@@ -2658,6 +2658,8 @@ js_TraceContext(JSTracer *trc, JSContext
 
     JS_CALL_VALUE_TRACER(trc, acx->iterValue, "iterValue");
 
+    acx->compartment->marked = true;
+
 #ifdef JS_TRACER
     TracerState* state = acx->tracerState;
     while (state) {

However:

kahoolawe:src gal$ curl http://hg.mozilla.org/tracemonkey | grep "/rev/"
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16737  100 16737    0     0   187k      0 --:--:--<tr class="parity0"><td class="link"><a href="/tracemonkey/rev/49abcb57270a">diff</a><br/><a href="/tracemonkey/file/49abcb57270a">browse</a></td><td class="age">49abcb57270a<br/><i>2010-07-12 23:46 -0700</i></td><td><strong><cite>Robert Sayre</cite> - Mark a few bidi tests random. see <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=578286">bug 578286</a>.

Comment 1

[Aravind Gottipati [:aravind]]

I flushed the cache on the server.  This should have automatically happened when you pushed to the repo.  Looking into why it didn't.

Comment 2

[Aravind Gottipati [:aravind]]

I think I found the problem, you were pushing with //tracemonkey, which is not a problem on the server, since unix handles it fine, but my meticulously constructed purge script didn't strip the leading //.