Closed Bug 578565 Opened 10 years ago Closed 10 years ago
We can probably remove both interfaces.
Currently percolating through try
Assignee: nobody → me
Status: NEW → ASSIGNED
Comment on attachment 457273 [details] [diff] [review] Remove nsIXBLDocumentInfo Tryserver approves. I have another patch on top of this to fix all of the method signatures that I'll post later.
Attachment #457273 - Flags: review?(jst)
Comment on attachment 457327 [details] [diff] [review] Fixup method signatures nsCOMPtr<nsIDocument> document; - rv = docInfo->GetDocument(getter_AddRefs(document)); - NS_ENSURE_SUCCESS(rv, nsnull); + document = docInfo->GetDocument(); There's a bunch of code in this patch that follows the same pattern. If you're up to it, please change this to be: + nsCOMPtr<nsIDocument> document = docInfo->GetDocument(); IOW, one less line of source in these cases. r=jst either way.
Attachment #457327 - Flags: review?(jst) → review+
Yeah I'll hit those on checkin.
http://hg.mozilla.org/mozilla-central/rev/b83386e574d2 http://hg.mozilla.org/mozilla-central/rev/e4db57316e6f Leaving open pending deCOMtaminating nsIXBLService.
10 years ago
Component: Tracking → XBL
QA Contact: chofmann → xbl
Resolving this. nsIXBLService is used from widget/ on Mac so it can't be removed in a non-libxul configuration.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.