Closed Bug 578590 Opened 11 years ago Closed 11 years ago

extraneous dereference in JSAtomList::rawLookup

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dherman, Assigned: dherman)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

jsatom.cpp, line 1069:

    ale = *hep ? (JSAtomListElement *) *hep : NULL;

should be

    ale = (JSAtomListElement *) *hep;

Itty bitty patch impending, forthwith. Verily.

Dave
It ain't rocket science.

Dave
Attachment #457253 - Flags: review?(brendan)
Attachment #457253 - Flags: review?(brendan) → review+
Pushed.

Dave
We prefer changeset URLs when marking as pushed, since Mercurial makes it so easy to get a nice change view.  :-)  (Some people used to post screenfuls of |cvs commit| output, when we used CVS.  It was pretty awful, and doing so was far less common as a result.)  And make sure to flag as fixed-in-tracemonkey if that's where you pushed a fix.

http://hg.mozilla.org/tracemonkey/rev/207f3548ff02
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
/me nods. Thanks for the info. I'll get it right next time. :)

Dave
http://hg.mozilla.org/mozilla-central/rev/207f3548ff02
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.