Transport of key events to plugin in window-less case is incomplete for Qt backend

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
2 years ago

People

(Reporter: steffen.imhof, Unassigned)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 457311 [details] [diff] [review]
Adds XKeyEvent data to events for plugins (gathered from previously stored QEvent)

The nsObjectFrame processes events to send them through the NPAPI later on. There is GTK2 specific code that restores information needed to fill in an XKeyEvent from a GTK event stored in the nsEvent.

There is no corresponding part for Qt. The attached patch is supposed to fix that.

(I used Widget:Qt as component for now, because it is quite Qt specific, on the other hand the affected code is under layout, so if needed please adjust)
(Reporter)

Updated

9 years ago
Attachment #457311 - Flags: review?(doug.turner)
Comment on attachment 457311 [details] [diff] [review]
Adds XKeyEvent data to events for plugins (gathered from previously stored QEvent)

wow, this is an ugly ass method....
Attachment #457311 - Flags: review?(doug.turner) → review+
http://hg.mozilla.org/mozilla-central/rev/50f1af16f861
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Attachment #457311 - Attachment is patch: true
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.