Closed
Bug 578809
Opened 15 years ago
Closed 15 years ago
Jetpack callMessage should be RPC, not sync
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
|
3.58 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
I'm pretty sure we want jetpack .callMessage to be RPC, not sync. The only case it really matters is where the receiver (chrome) does .createHandle, and then returns that handle in the response, but I've hit this case at least once and it seems like a footgun.
bent/bnewman/cjones, do you have any history for why it is currently sync?
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #457397 -
Flags: review?(bent.mozilla)
|
||
Updated•15 years ago
|
Attachment #457397 -
Attachment is patch: true
Attachment #457397 -
Attachment mime type: application/octet-stream → text/plain
Comment on attachment 457397 [details] [diff] [review]
Make it RPC, rev. 1
I can't think of any reason off the top of my head besides "best practices". If we have a case that needs RPC then we should do it.
Attachment #457397 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Updated•15 years ago
|
blocking2.0: --- → betaN+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Pushed this on 23-July.
http://hg.mozilla.org/mozilla-central/rev/07b96641ab93
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•