Closed Bug 578809 Opened 11 years ago Closed 11 years ago

Jetpack callMessage should be RPC, not sync

Categories

(Core :: XPCOM, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

I'm pretty sure we want jetpack .callMessage to be RPC, not sync. The only case it really matters is where the receiver (chrome) does .createHandle, and then returns that handle in the response, but I've hit this case at least once and it seems like a footgun.

bent/bnewman/cjones, do you have any history for why it is currently sync?
Attachment #457397 - Flags: review?(bent.mozilla)
Attachment #457397 - Attachment is patch: true
Attachment #457397 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 457397 [details] [diff] [review]
Make it RPC, rev. 1

I can't think of any reason off the top of my head besides "best practices". If we have a case that needs RPC then we should do it.
Attachment #457397 - Flags: review?(bent.mozilla) → review+
blocking2.0: --- → betaN+
Pushed this on 23-July.
http://hg.mozilla.org/mozilla-central/rev/07b96641ab93
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.