Need to: a) stop looping on failures b) throw so sync aborts and we do the proper wipe later
Created attachment 457552 [details] [diff] [review] v1 This patch makes wipeServer() abort if it encounters a server error (anything other than 200 or 404) and throw an exception. We also no longer catch any exceptions wipeServer() throws but let them bubble up to the callers. All callers, direct or indirect, have a this._catch() wrapper of their own but should really fail if wipeServer() fails.
Assignee: nobody → philipp
Attachment #457552 - Flags: review?(mconnor)
Created attachment 463164 [details] [diff] [review] v1.1 Updated test to not leak (as discussed in bug 583949). No code changes.
Attachment #463164 - Flags: review?(mconnor) → review+
1.4.x: http://hg.mozilla.org/services/fx-sync/rev/a4fb3c8e8549 default: http://hg.mozilla.org/services/fx-sync/rev/570d035184ce
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.