578842 - 'cfx testall -a firefox' is broken on latest Firefox 4.0b2pre nightlies

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

Whenever I run 'cfx testall -a firefox' with the latest nightlies, the test suite hangs here:

  Testing all available packages: nsjetpack, test-harness, jetpack-core,  
  development-mode.

Firefox opens, but no errors appear in the JS error console (aside from "Warning: unrecognized command line flag -foreground", which has been around for a while on OS X), nor on stdout.

This appears to be happening to peregrino and Myk too. Myk is using Linux and I'm using OS X.

Comment 1

[Atul Varma [:atul]]

Note also that this is after the patch for bug 578432 has landed, so install.rdf maxVersion shouldn't be an issue here. In fact, going to the Add-ons Manager while Firefox is "hanging" does show the test harness addon as being installed and enabled.

Comment 2

[Dietrich Ayala (:dietrich)]

what do you see when you try cfx run inside a package dir? because that's failing for me on nightlies.

Comment 3

[Atul Varma [:atul]]

Ok, found it with Mossop's help... It's bug 568691 that's causing the harness.js XPCOM component to not be loaded. In order to fix this, we either need to have cfx create a chrome.manifest in the extension dir with harness.js's cid info in it, or, now that bug 566485 is fixed, actually fix bug 566723. I'm going to go for the latter since it's both a cleaner fix and requires less work.

Comment 4

[Atul Varma [:atul]]

Attachment: patch

Comment 5

[Atul Varma [:atul]]

Comment on attachment 458472 [details] [diff] [review]
patch

Mossop, can you take a quick look at this and let me know if it looks sane?

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 458472 [details] [diff] [review]
patch

Looks good, though I might suggest adding a comment in harness.js above NSGetModule saying that everything below there is only used on Gecko 1.9.2.

Comment 7

[Atul Varma [:atul]]

Thanks! I added the comment and pushed:

Bug 578842 - 'cfx testall -a firefox' is broken on latest Firefox 4.0b2pre nightlies
Atul Varma
http://hg.mozilla.org/labs/jetpack-sdk/rev/ca9796a2a6aa

Comment 9

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".