Closed Bug 578943 Opened 14 years ago Closed 14 years ago

window.console object exposes more objects then just console API

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: julian.viereck, Assigned: julian.viereck)

References

Details

Attachments

(1 file, 1 obsolete file)

[checked in] Patch v2
5.79 KB, patch
Details | Diff | Splinter Review 
The window.console object added to the observed page exposes some internal object. Ensure that only API functions can be accessed from the webpage.
Attached patch Patch (obsolete) — — Splinter Review 
This patch applies after the patches from bug #576962 are applied.
Assignee: nobody → jviereck
Status: NEW → ASSIGNED
Attachment #457553 - Flags: review?(dietrich)
Comment on attachment 457553 [details] [diff] [review]
Patch


>+
>+  this.exception = function console_exception()
>+  {
>+    sendToHUDService("exception", arguments);
>+   }
> };

fix indent.

r=me, thanks for catching this!
Attachment #457553 - Flags: review?(dietrich) → review+
Fixes indention as mentioned by reviewer.

Note: needs patch from bug 576962 applied.
Attachment #457553 - Attachment is obsolete: true
Depends on: 576962
Whiteboard: checkin-needed
Blocks: 576963
Comment on attachment 457672 [details] [diff] [review]
[checked in] Patch v2

changeset:   47819:70aa61505c8f
user:        Julian Viereck <jviereck@mozilla.com>
date:        Fri Jul 16 12:47:24 2010 -0300
summary:     bug 578943 - window.console object exposes more objects then just console API
Attachment #457672 - Attachment description: Patch v2 → [checked in] Patch v2
Whiteboard: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: