Closed Bug 578946 Opened 14 years ago Closed 14 years ago

Return values null and undefined are not logged to console output

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julian.viereck, Assigned: julian.viereck)

References

Details

Attachments

(1 file, 1 obsolete file)

If a function returns undefined this is not logged to the console. If the return value is null, a new output line is added but without any content.
Attached patch Patch (obsolete) — Splinter Review
This bug applies only after the patches of bug 576963 are applied.
Attachment #457559 - Flags: review?(dietrich)
Comment on attachment 457559 [details] [diff] [review]
Patch


>+      else if (result === undefined) {
>+        this.writeOutput('undefined');
>+      }
>+      else if (result === null) {
>+        this.writeOutput("null");
>+      }

please use either single or double quotes consistently, and whichever the way it's used elsewhere in this file.

>+
>+  is (outputChildren[1].childNodes[0].nodeValue, "null",
>+                                              "'null' printed to output");
>+

fix indent

r=me
Attachment #457559 - Flags: review?(dietrich) → review+
Same patch as before but with small fixes requested by reviewer.

This bug applies only after the patches of bug 576963 are applied.
Attachment #457559 - Attachment is obsolete: true
Depends on: 576963
Whiteboard: checkin-needed
Comment on attachment 457675 [details] [diff] [review]
[checked-in] Patch v2

changeset:   47820:1c7a77f65f9b
tag:         tip
user:        Julian Viereck <jviereck@mozilla.com>
date:        Fri Jul 16 12:55:35 2010 -0300
summary:     bug 578946 - Return values null and undefined are not logged to console output
Attachment #457675 - Attachment description: Patch v2 → [checked-in] Patch v2
Whiteboard: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: