Closed
Bug 578946
Opened 15 years ago
Closed 15 years ago
Return values null and undefined are not logged to console output
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: julian.viereck, Assigned: julian.viereck)
References
Details
Attachments
(1 file, 1 obsolete file)
3.46 KB,
patch
|
Details | Diff | Splinter Review |
If a function returns undefined this is not logged to the console. If the return value is null, a new output line is added but without any content.
Assignee | ||
Comment 1•15 years ago
|
||
This bug applies only after the patches of bug 576963 are applied.
Attachment #457559 -
Flags: review?(dietrich)
Comment 2•15 years ago
|
||
Comment on attachment 457559 [details] [diff] [review]
Patch
>+ else if (result === undefined) {
>+ this.writeOutput('undefined');
>+ }
>+ else if (result === null) {
>+ this.writeOutput("null");
>+ }
please use either single or double quotes consistently, and whichever the way it's used elsewhere in this file.
>+
>+ is (outputChildren[1].childNodes[0].nodeValue, "null",
>+ "'null' printed to output");
>+
fix indent
r=me
Attachment #457559 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Same patch as before but with small fixes requested by reviewer.
This bug applies only after the patches of bug 576963 are applied.
Attachment #457559 -
Attachment is obsolete: true
Comment 4•15 years ago
|
||
Comment on attachment 457675 [details] [diff] [review]
[checked-in] Patch v2
changeset: 47820:1c7a77f65f9b
tag: tip
user: Julian Viereck <jviereck@mozilla.com>
date: Fri Jul 16 12:55:35 2010 -0300
summary: bug 578946 - Return values null and undefined are not logged to console output
Attachment #457675 -
Attachment description: Patch v2 → [checked-in] Patch v2
Updated•15 years ago
|
Whiteboard: checkin-needed
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•