Closed Bug 579100 Opened 14 years ago Closed 14 years ago

eliminating leftovers of heap-allocated doubles from jsgc.cpp

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: igor, Assigned: igor)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

v2
30.89 KB, patch
gwagner
: review+
Details | Diff | Splinter Review 
As a leftover of slim values era jsgc.cpp still contains a few comments or struct definitions related to heap-allocated doubles. That should be removed.
Summary: eliminating traces of heap-allocated doubles from jsgc.cpp → eliminating leftovers of heap-allocated doubles from jsgc.cpp
There is also the HasMarkedDoubles function left.
Attached patch v1 (obsolete) — — Splinter Review 
Besides fixing comments/structs to remove double GC heap leftovers the patch does few more cleanups. In particular, JSGCTracer is renamed into js::GCMarker and all delayed marking-related fields are moved there from JSRuntime.
Attachment #460076 - Flags: review?(anygregor)
Attached patch v2 — — Splinter Review 
here comes the proper patch - v1 is not finished version.
Attachment #460076 - Attachment is obsolete: true
Attachment #460080 - Flags: review?(anygregor)
Attachment #460076 - Flags: review?(anygregor)
Attachment #460080 - Flags: review?(anygregor) → review+
http://hg.mozilla.org/tracemonkey/rev/eb6c9591249e
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/eb6c9591249e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
could this have caused a regression in found in bug 579100
er, bug 594859
(In reply to comment #7)
> er, bug 594859

The bug was mostly about renames and removal of unused functionality. The stack reported in 594859 just reflects this changes.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: