Remove unneeded special extensions

RESOLVED FIXED

Status

Other Applications
Narcissus
--
minor
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Tom Austin, Assigned: Tom Austin)

Tracking

Other Branch
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Since Narcissus no longer relies on a special build, these components can be removed from the C++ code (basically, everything in '#ifdef NARCISSUS' blocks).
(Assignee)

Comment 1

8 years ago
There is some reference to Narcissus in testing/sisyphus/bin/set-build-env.sh:
        -narcissus)
            export XCFLAGS="-DNARCISSUS=1"
            export CFLAGS="-DNARCISSUS=1"
            export CXXFLAGS="-DNARCISSUS=1"
            ;;

These lines should probably be removed, though I'm not sure how this script is used to test it out.
(Assignee)

Comment 2

8 years ago
Created attachment 457687 [details] [diff] [review]
Patch strips out '#ifdef NARCISSUS' constructs
Attachment #457687 - Flags: review?(gal)

Updated

8 years ago
Attachment #457687 - Flags: review?(gal) → review+
(Assignee)

Comment 3

7 years ago
Changeset: http://hg.mozilla.org/tracemonkey/rev/2e96b91da603
Whiteboard: fixed-in-tracemonkey

Updated

7 years ago
Component: JavaScript Engine → Narcissus
Keywords: narcissus
Product: Core → Other Applications
QA Contact: general → narcissus

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/2e96b91da603
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.