579159 - Handle the Windows 7.1 SDK in guess-msvc.bat

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Armen [:armenzg]]

Attachment: load the Windows 7.1 SDK

This is a pretty recent SDK but would be nice to take it with MB1.5 if possible.

http://www.microsoft.com/downloads/details.aspx?familyid=35AEDA01-421D-4BA5-B44B-543DC8C33A20&displaylang=en

Comment 1

[Armen [:armenzg]]

Attachment: load the Windows 7.1 SDK (v2)

This is the interdiff between these two patches.
I want to use this SDK for the Windows 64-bit if possible.

Armen-Zambrano-Gasparnians-MacBook:patches armenzg$ diff sdk7.1.v1.diff sdk7.1.v2.diff 
29c29
< +if "%SDKDIR%"=="" (
---
> +if "%SDKDIR%"=="" IF %MOZ_MAXWINSDK% GEQ 70100 (
31c31
< +    FOR /F "tokens=2* usebackq delims=        " %%A IN (`REG QUERY "%SDK71KEY%" /v InstallationFolder`) DO SET SDKDIR=%%B
---
> +    FOR /F "tokens=2* usebackq delims=  " %%A IN (`REG QUERY "%SDK71KEY%" /v InstallationFolder`) DO SET SDKDIR=%%B

Comment 2

[Armen [:armenzg]]

OK No worries about not taking this on 1.5 release.
We can get it in for the next one.

This has low priority for me.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 458371 [details] [diff] [review]
load the Windows 7.1 SDK (v2)

Looks fine.

Comment 4

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/mozilla-build/rev/dcf47658bbd5

Comment 9

[Steve Lee]

Be VERY careful of pasting the new FOR line from the web views above when manually applying patch. There is a TAB char after delims= which gets lost and will break this patch (build of widget/src/Windows/ will break). This kept me busy for some time

Comment 10

[Mounir Lamouri (:mounir)]

FWIW, applying this patch locally didn't solve the issue. I had to download guess-msvc.bat from the mozilla-build repository.

Comment 11

[Steffen Wilberg]

So just save the file from here:
http://hg.mozilla.org/mozilla-build/raw-file/tip/guess-msvc.bat