Closed Bug 579159 Opened 14 years ago Closed 14 years ago

Handle the Windows 7.1 SDK in guess-msvc.bat

Categories

(Firefox Build System :: MozillaBuild, task)

x86
Windows XP
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: armenzg)

References

Details

(Whiteboard: [target Mozilla-Build 1.6])

Attachments

(1 file, 1 obsolete file)

Attached patch load the Windows 7.1 SDK (obsolete) — Splinter Review
This is a pretty recent SDK but would be nice to take it with MB1.5 if possible.

http://www.microsoft.com/downloads/details.aspx?familyid=35AEDA01-421D-4BA5-B44B-543DC8C33A20&displaylang=en
Attachment #457667 - Flags: review?(ted.mielczarek)
This is the interdiff between these two patches.
I want to use this SDK for the Windows 64-bit if possible.

Armen-Zambrano-Gasparnians-MacBook:patches armenzg$ diff sdk7.1.v1.diff sdk7.1.v2.diff 
29c29
< +if "%SDKDIR%"=="" (
---
> +if "%SDKDIR%"=="" IF %MOZ_MAXWINSDK% GEQ 70100 (
31c31
< +    FOR /F "tokens=2* usebackq delims=        " %%A IN (`REG QUERY "%SDK71KEY%" /v InstallationFolder`) DO SET SDKDIR=%%B
---
> +    FOR /F "tokens=2* usebackq delims=  " %%A IN (`REG QUERY "%SDK71KEY%" /v InstallationFolder`) DO SET SDKDIR=%%B
Attachment #457667 - Attachment is obsolete: true
Attachment #458371 - Flags: review?(ted.mielczarek)
Attachment #457667 - Flags: review?(ted.mielczarek)
OK No worries about not taking this on 1.5 release.
We can get it in for the next one.

This has low priority for me.
Whiteboard: [target Mozilla-Build 1.6]
Comment on attachment 458371 [details] [diff] [review]
load the Windows 7.1 SDK (v2)

Looks fine.
Attachment #458371 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → armenzg
http://hg.mozilla.org/mozilla-build/rev/dcf47658bbd5
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Mac OS X → Windows XP
Resolution: --- → FIXED
Summary: Load the Windows 7.1 SDK on guess-msvc.bat → Handle the Windows 7.1 SDK in guess-msvc.bat
Blocks: 603076
Be VERY careful of pasting the new FOR line from the web views above when manually applying patch. There is a TAB char after delims= which gets lost and will break this patch (build of widget/src/Windows/ will break). This kept me busy for some time
FWIW, applying this patch locally didn't solve the issue. I had to download guess-msvc.bat from the mozilla-build repository.
No longer blocks: 754810
Product: mozilla.org → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: