Closed Bug 579222 Opened 12 years ago Closed 12 years ago

Expose a .visibleTabs property on the tabbrowser

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Instead of having browser.js, tabbrowser.xml, etc. using TabCandy.getVisibleTabs(), we can just expose it as part of tabbrowser.
Attached patch v1Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #457727 - Flags: review?(ian)
Comment on attachment 457727 [details] [diff] [review]
v1

Looks good to me. Fire at will.
Attachment #457727 - Flags: review?(ian) → review+
Actually, one thing. As long as you're doing this, perhaps you should kill Tabbar.getVisibleTabCount() and just use the new .visibleTabs.length?
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/e26ed60039cd
Add .visibleTabs to tabbrowser and use local dereferences instead of gBrowser when possible.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 579511
Mardak, Ian, Aza: This patch to tabbrowser.xml and to browser-places seems like a good candidate for submitting against trunk as a small, self-contained patch. (Hereafter to be referred to as the "baby steps" approach to getting on trunk)

Thoughts?
Sounds good to me... Mardak, if you agree, can you do so?
There would probably need to be a more complete audit of tabs -> visibleTabs for the patch.

Like tabbrowser.selectTabAtIndex should probably use .visibleTabs to handle cmd-1 and cmd-9, etc.

Except tabcandy currently jumps in and (incorrectly) re-implements these cmd-# presses:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/file/25fb05ea9878/browser/base/content/tabcandy/app/ui.js#l912

Incorrect in that cmd-9 should select the last tab and not the 9th tab.
Blocks: 581286
Blocks: 581732
Blocks: 582116
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Now documented here:

https://developer.mozilla.org/en/XUL/Property/visibleTabs

And linked from:

https://developer.mozilla.org/en/XUL/tabbrowser

With a mention on Firefox 4 for developers as appropriate.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.