579222 - Expose a .visibleTabs property on the tabbrowser

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ed Lee :Mardak]

Instead of having browser.js, tabbrowser.xml, etc. using TabCandy.getVisibleTabs(), we can just expose it as part of tabbrowser.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 457727 [details] [diff] [review]
v1

Looks good to me. Fire at will.

Comment 3

[Ian Gilman [:iangilman]]

Actually, one thing. As long as you're doing this, perhaps you should kill Tabbar.getVisibleTabCount() and just use the new .visibleTabs.length?

Comment 4

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/e26ed60039cd
Add .visibleTabs to tabbrowser and use local dereferences instead of gBrowser when possible.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Mardak, Ian, Aza: This patch to tabbrowser.xml and to browser-places seems like a good candidate for submitting against trunk as a small, self-contained patch. (Hereafter to be referred to as the "baby steps" approach to getting on trunk)

Thoughts?

Comment 6

[Ian Gilman [:iangilman]]

Sounds good to me... Mardak, if you agree, can you do so?

Comment 7

[Ed Lee :Mardak]

There would probably need to be a more complete audit of tabs -> visibleTabs for the patch.

Like tabbrowser.selectTabAtIndex should probably use .visibleTabs to handle cmd-1 and cmd-9, etc.

Except tabcandy currently jumps in and (incorrectly) re-implements these cmd-# presses:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/file/25fb05ea9878/browser/base/content/tabcandy/app/ui.js#l912

Incorrect in that cmd-9 should select the last tab and not the 9th tab.

Comment 8

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 9

[Eric Shepherd [:sheppy]]

Now documented here:

https://developer.mozilla.org/en/XUL/Property/visibleTabs

And linked from:

https://developer.mozilla.org/en/XUL/tabbrowser

With a mention on Firefox 4 for developers as appropriate.