xpcshell should handle EINTR from fgets (makes attaching in gdb possible)
RESOLVED
FIXED
in mozilla7
Status
()
People
(Reporter: joe, Assigned: joe)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [inbound])
Attachments
(1 attachment, 1 obsolete attachment)
|
899 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
Created attachment 457754 [details] [diff] [review] handle EINTR Right now, xpcshell exits gracefully whenever it gets a NULL return value from fgets(). However, there are valid NULL return values possible from fgets(), like when it's interrupted by a system call. This patch makes xpcshell not exit in those cases, which makes attaching to xpcshell in GDB possible.
Attachment #457754 -
Flags: review?
|
(Assignee) | |
Comment 1•9 years ago
|
||
Created attachment 457758 [details] [diff] [review] handle EINTR v2 testing ftw
Assignee: nobody → joe
Attachment #457754 -
Attachment is obsolete: true
Attachment #457758 -
Flags: review?
Attachment #457754 -
Flags: review?
|
|
(Assignee) | |
Updated•9 years ago
|
Attachment #457758 -
Flags: review? → review?(timeless)
Comment on attachment 457758 [details] [diff] [review] handle EINTR v2 similar code exists in js/shell/js.cpp, please patch it too
Attachment #457758 -
Flags: review?(timeless) → review+
|
||
Comment 3•8 years ago
|
||
I hit this every time I start developing on a mac again. What do we need to do to get this into the tree still?
|
|
||
Comment 4•8 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/b7b987a52c33
Whiteboard: [inbound]
|
||
Comment 5•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b7b987a52c33
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•