Closed
Bug 579249
Opened 15 years ago
Closed 14 years ago
xpcshell should handle EINTR from fgets (makes attaching in gdb possible)
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: joe, Assigned: joe)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file, 1 obsolete file)
|
899 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
Right now, xpcshell exits gracefully whenever it gets a NULL return value from fgets(). However, there are valid NULL return values possible from fgets(), like when it's interrupted by a system call.
This patch makes xpcshell not exit in those cases, which makes attaching to xpcshell in GDB possible.
Attachment #457754 -
Flags: review?
|
Assignee | |
Comment 1•15 years ago
|
||
testing ftw
Assignee: nobody → joe
Attachment #457754 -
Attachment is obsolete: true
Attachment #457758 -
Flags: review?
Attachment #457754 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #457758 -
Flags: review? → review?(timeless)
Comment on attachment 457758 [details] [diff] [review]
handle EINTR v2
similar code exists in js/shell/js.cpp, please patch it too
Attachment #457758 -
Flags: review?(timeless) → review+
|
||
Comment 3•14 years ago
|
||
I hit this every time I start developing on a mac again. What do we need to do to get this into the tree still?
|
|
||
Comment 4•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•