579249 - xpcshell should handle EINTR from fgets (makes attaching in gdb possible)

Status: RESOLVED FIXED

Description

[Joe Drew (not getting mail)]

Created attachment 457754 [details] [diff] [review]
handle EINTR

Right now, xpcshell exits gracefully whenever it gets a NULL return value from fgets(). However, there are valid NULL return values possible from fgets(), like when it's interrupted by a system call. 

This patch makes xpcshell not exit in those cases, which makes attaching to xpcshell in GDB possible.

Comment 1

[Joe Drew (not getting mail)]

Created attachment 457758 [details] [diff] [review]
handle EINTR v2

testing ftw

Comment 2

[timeless]

Comment on attachment 457758 [details] [diff] [review]
handle EINTR v2

similar code exists in js/shell/js.cpp, please patch it too

Comment 3

[Josh Matthews [:jdm]]

I hit this every time I start developing on a mac again. What do we need to do to get this into the tree still?

Comment 4

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b7b987a52c33

Comment 5

[Marco Bonardo [::mak] (Away 4-20 August)]

http://hg.mozilla.org/mozilla-central/rev/b7b987a52c33