Need a test to check for "Inaccessible <prefpane>'s if not explicitly referenced by a <preftreeitem>"

NEW
Unassigned

Status

9 years ago
8 years ago

People

(Reporter: Callek, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

(Reporter)

Description

9 years ago
We should develop a test for our prefwindow that checks for inaccessible <prefpane>'s (due to a missing <preftreeitem> reference).

Found this fruit while reveiwing: https://wiki.mozilla.org/User:Callek/Prefwindow_API_Variants  We just need someone to pick it.

Comment 1

8 years ago
preferences.xml:
          // append any still unreferenced <prefpane>s to the tree's top level
So how would you tell it's unreferenced?
(Reporter)

Comment 2

8 years ago
(In reply to comment #1)
> preferences.xml:
>           // append any still unreferenced <prefpane>s to the tree's top level
> So how would you tell it's unreferenced?

O suuure, lets believe the code rather than a pre-landing design document.

Given the code though, I wonder in rough passing if a console warning is worthwhile, or if doing this as "supported" XUL design for us is better.

However, this bug is not necessarily invalid; as a test that under normal preferences-XUL code we won't hit just ensures the correctness of our preferences-XUL code. but does lower the priority here for me.

Comment 3

8 years ago
> Given the code though, I wonder in rough passing if a console warning is
> worthwhile, or if doing this as "supported" XUL design for us is better.
Sure nsIConsoleService::logStringMessage() appears to be suitable.
You need to log in before you can comment on or make changes to this bug.