579272 - context menu background is transparent

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Karsten Düsterloh]

Right clicking results in a context menu with transparent background, because
<popup> is gone from toolkit now.
Compare SeaMonkey bug 578876 and bug 578440.

Comment 1

[[e-mail]]

Attachment: Port of attachment 458136 (ChatZilla)

Comment 2

[:Gijs (he/him)]

Comment on attachment 459830 [details] [diff] [review]
Port of attachment 458136 [details] [diff] [review] (ChatZilla)

Assuming you tested this (and also, wtf?) -- r=me.

Comment 3

[:Gijs (he/him)]

(In reply to comment #2)
> Comment on attachment 459830 [details] [diff] [review]
> Port of attachment 458136 [details] [diff] [review] (ChatZilla)
> 
> Assuming you tested this (and also, wtf?) -- r=me.

Whoa, actually, please to be fixing that whitespace before the function arguments. Thanks!

Comment 4

[[e-mail]]

(In reply to comment #2)
> (and also, wtf?)
Pinstripe was accumulating duplicate style rules, and it was getting silly. In particular it needed rules for checkboxes in a popup but not in a menulist.

(In reply to comment #3)
> Whoa, actually, please to be fixing that whitespace before the function
> arguments. Thanks!
Sorry, all I did was to prefix the word "menu" to the word "popup". Is this a style change that needs to be incrementally applied to subsequent changes?

Comment 5

[:Gijs (he/him)]

(In reply to comment #4)
> (In reply to comment #2)
> > (and also, wtf?)
> Pinstripe was accumulating duplicate style rules, and it was getting silly. In
> particular it needed rules for checkboxes in a popup but not in a menulist.
> 
> (In reply to comment #3)
> > Whoa, actually, please to be fixing that whitespace before the function
> > arguments. Thanks!
> Sorry, all I did was to prefix the word "menu" to the word "popup". Is this a
> style change that needs to be incrementally applied to subsequent changes?

Oh, yes. Sorry, the 'Woah' was not intended at you -  no need for you to apologize! - there is just not so much code which still has this old style (that I regularly look at), so I overlooked it initially, and was surprised. We try and fix it incrementally, indeed. Thanks!

Comment 6

[[e-mail]]

Pushed changeset 015647fa7868 to venkman.