Closed Bug 579316 Opened 12 years ago Closed 12 years ago

warning: "LOCAL_GL_MAX_VARYING_VECTORS" redefined

Categories

(Core :: Canvas: WebGL, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

content/canvas/src/WebGLContextGL.cpp:
1335:1: warning: "LOCAL_GL_MAX_VARYING_VECTORS" redefined
In file included from ../../../dist/include/GLContext.h:50,
                 from content/canvas/src/WebGLContext.h:60,
                 from content/canvas/src/WebGLContextGL.cpp:41:
../../../dist/include/GLDefs.h:
3027:1: warning: this is the location of the previous definition
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #457833 - Flags: review?(bjacob)
Comment on attachment 457833 [details] [diff] [review]
patch

Indeed, LOCAL_GL_MAX_VARYING_VECTORS was added by Vladimir to GLDefs.h in changeset 0895c4370e7ac. I didn't realize that we could put ES stuff in GLDefs.h --- why not!
Attachment #457833 - Flags: review?(bjacob) → review+
http://hg.mozilla.org/mozilla-central/rev/6467768788e4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.