Closed Bug 579412 Opened 11 years ago Closed 11 years ago

Focus inputNode on JSTerm when opening the HUD/Console

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(blocking2.0 betaN+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: julian.viereck, Assigned: pcwalton)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch [backed-out] Patch (obsolete) — Splinter Review
When you open up the HUD/Console, the inputNode is not focused.

The inputNode should be focused to increate the workflow.
Attachment #457897 - Flags: review?(dietrich)
Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

much nicer, r=me, thanks!
Attachment #457897 - Flags: review?(dietrich) → review+
Whiteboard: [checked-in]
Whiteboard: [checked-in] → [checkin-needed]
Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

Requesting approval as this patch improves the UX for the WebConsole. Instead of opening the WebConsole and setting the focus to the inputNode to start typing/testing thing the focus is set to the inputNode automatically when the WebConsole is opened. This one step less to do speeds up development/testing for the WebConsole also.
Attachment #457897 - Flags: approval2.0?
blocking2.0: --- → betaN+
Attachment #457897 - Flags: approval2.0?
Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

http://hg.mozilla.org/mozilla-central/rev/b993e9c8edbe
Attachment #457897 - Attachment description: Patch → [checked-in] Patch
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Did this cause some failures
had to backout due to test failures.

see, http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1279891381.1279892248.10989.gz

for example.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

need a fix for test failures
Attachment #457897 - Attachment description: [checked-in] Patch → [backed-out] Patch
Whiteboard: [need fix for test errors]
Attached patch New proposed patch. (obsolete) — Splinter Review
New patch. The "jsterm" property is only defined immediately after the console is created, which was causing the test failures. Mochitests now pass.
Assignee: jviereck → pwalton
Attachment #457897 - Attachment is obsolete: true
Attachment #459885 - Flags: review?(dtownsend)
Blocks: consoleui
Whiteboard: [need fix for test errors]
Comment on attachment 459885 [details] [diff] [review]
New proposed patch.

Rescinding review request due to lack of unit tests.
Attachment #459885 - Flags: review?(dtownsend)
New proposed patch, version 2, with a mochitest.
Attachment #459885 - Attachment is obsolete: true
Attachment #459959 - Flags: review?(dtownsend)
Attachment #459959 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7ca4b43c3210
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
FWIW, querySelectorAll(x)[0] == querySelector(x), and the latter could be a little more efficient.
I was thinking the same thing as above in Comment 11. Otherwise, this is checked in so it should be a follow-up bug.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.