579487 - Better error reporting when NS_CreateServicesFromCategory can't find a contract

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benjamin Smedberg]

Attachment: NS_CreateServicesFromCategory error reporting to the console, rev. 1

One of the common issues that's showing up with extension authors and profile-after-change is that they can't debug issues in the category registration. A simple aid is to report errors where a category entry exists in profile-after-change but the service either cannot be created or does not implement nsIObserver properly.

Comment 1

[Benjamin Smedberg]

Attachment: NS_CreateServicesFromCategory error reporting to the console, rev. 1

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 457936 [details] [diff] [review]
NS_CreateServicesFromCategory error reporting to the console, rev. 1

I have slight concerns with this. I have seen cases where extensions add profile-after-change services but don't implement nsIObserver, they should do what they want in their constructor.

I even recall making an odd suggestion the other day for someone that wanted do something at profile-after-change without keeping a service alive for the entire app where I suggested their factory simply do whatever startup they wanted and then not return an instance.

Both of these case would throw errors even though they are sort of intentional. I don't think it is a big deal just wonder how many cases like this there are going to be filling up the console.

Comment 3

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/c271aa43c7ab