579494 - Autogenerate toolkit-makefiles.sh

Status: RESOLVED DUPLICATE of bug 784841

(Firefox Build System :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

Spun off from bug 571989 comment 24.

Zack Weinberg (:zwol) wrote:

> Couldn't we run (the equivalent of) 'find . -name Makefile.in' at the end of
> configure, rather than having this list that has to be kept up to date
> manually?  It presumably does not matter if a few Makefiles get generated even
> though they won't be used.  I suppose we would need a blacklist for things like
> js and nspr that have their own configure scripts, but that would be easier to
> keep up to date.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This should be doable.  Patches welcome ;-)

Comment 2

[(not currently active) Ted Mielczarek]

The only downside is that "find . -name Makefile.in" is always going to take longer than hardcoding a list of Makefiles. (It took almost 30 seconds the first time on my Linux machine, but only about 0.3s afterwards.)

Comment 3

[Phil Ringnalda (:philor)]

What slowness is toolkit-makefiles.sh actually a horrible hackaround for, and how does that slowness compare to find's slowness?

Comment 4

[(not currently active) Ted Mielczarek]

AIUI, it's supposedly faster than asking Make to realize every Makefile needs to be generated and run the rules to generate them while building. (via: http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1634 )

Comment 5

[Benjamin Smedberg]

Yes, rebuilding each makefile individually spawns a bunch of perl processes which are horribly slow to launch (especially on Windows).

Comment 6

[Gregory Szorc [:gps]]

The makefiles.sh files went away with bug 784841.