579509 - Make sure iPhone client correctly handles case insensitive usernames

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Ed Lee :Mardak]

The add-on switched to lowercase in bug 532570 to avoid problems of differently cased javascript-hashobject-lookup failing for the pubkey -> symmetrickey mapping.

Comment 1

[Ed Lee :Mardak]

I would assume it's this bit of code:

http://hg.mozilla.org/services/fx-home/file/31eaa3613485/Network%20And%20Storage/CryptoUtils.m#l611

It's generating a "keyIndex" based on the username for the public key, and when it tries to NSDictionary *selectedKey = [keyring objectForKey:keyURL], it'll find nothing.

Comment 3

[Tony Chung [:tchung]]

I"m going to mark this as Reso and Verified Fixed due to fix in bug 532570

Comment 4

[Tony Chung [:tchung]]

(In reply to comment #3)
> I"m going to mark this as Reso and Verified Fixed due to fix in bug 532570

Looks like i jumped the gun.  It is verified and fixed on Firefox 1.0.1 beta build.  However, Dan, can you please update the bug status with your changeset to make it official.

Thanks,
Tony

Comment 5

[Dan Walkowski]

fixed in changeset 8c270b61f936

Comment 6

[Ed Lee :Mardak]

I don't see any case changing code in http://hg.mozilla.org/services/fx-home/rev/8c270b61f936 ?

Comment 7

[Dan Walkowski]

sorry, changeset 1464c1b8098a

Comment 8

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-home/rev/1464c1b8098a

Comment 9

[Tony Chung [:tchung]]

Verified fix on FF Home 1.0.1.

Comment 10

[Tony Chung [:tchung]]

Moving FFHome-related bugs to new component -> Firefox Home