579513 - Force updating metadata for add-ons in the application directory when the app upgrades

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We used to do this since sometimes the installer/updater can't touch the extension directory's mtime so we just refresh all the data anyway.

Comment 1

[Robert Strong (they/them - no direct email)]

This should only need to happen on app version changes and not all app upgrades.

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple patch, horrible test. We can't override where the application extensions are found so this writes one to wherever the xpcshell process is running and attempts to clean up sanely afterwards.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 458038 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>@@ -1650,20 +1650,22 @@ var XPIProvider = {
>         addons.forEach(function(aOldAddon) {
>           // Check if the add-on is still installed
>           if (aOldAddon.id in addonStates) {
>             let addonState = addonStates[aOldAddon.id];
>             delete addonStates[aOldAddon.id];
> 
>             // The add-on has changed if the modification time has changed, or
>             // the directory it is installed in has changed or we have an
>-            // updated manifest for it.
>+            // updated manifest for it. Also force reloading metadata for add-ons
>+            // in the application directory when the application has changed
nit: Also, reload the metadat for add-ons in the application directory when the application version has changed.

Comment 4

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/f75c9b43e5af

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed based on checkin and passing test.