579529 - fix validation Uniform and VertexAttrib functions taking arrays

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

E.g. this page,

    http://www.khronos.org/opengles/sdk/2.0/docs/man/glUniform.xml

mentions several things we're not currently checking. Most importantly, we're not actually checking that the passed array is big enough, we only have a strange 'modulo' check that I can't match with anything in the GLES docs. As a result, tests are failing, e.g. gl-uniformmatrix4fv.html reports:

    Checking gl.uniformMatrix.
    FAIL should fail with insufficient array size for uniformMatrix2fv

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: small fix in uniform array validation

Actually, the only problem seems to be that we generate INVALID_OPERATION and the test expects INVALID_VALUE and has a very confusing error message.

This patch changes that, and also improves a bit our own error message.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

cool, confirming that with this patch, gl-uniformmatrix4fv.html is all green.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/f0a62833d988

But please approve!