579573 - Stop sending talos sendchanges to talos masters for try

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: turn off talos sendchanges to test-masters

Instead of running talos by default on try we can save resources by turning it off and on the occasion that someone needs a talos run they can request the buildduty sheriff from RelEng do the sendchange to the actual masters. Will keep a dummy localhost in the talos-masters list so that all the info needed for a sendchange will be in the build's log/steps.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

We should have a checkbox on the tryserver webpage that allows users to do this without having to figure out who the buildduty sheriff is and running them down. Even if that just results in a bug being filed, it's a better user experience.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to comment #1)
> We should have a checkbox on the tryserver webpage 

There is not currently a tryserver webpage so while this would be a better user experience it's not possible with the reality of push to try. It's unfortunate that someone who wants Talos on their try run needs to come find one of us but we truly believe that very few of the daily pushes to try will be resulting in this type of request.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 458009 [details] [diff] [review]
turn off talos sendchanges to test-masters

I think I'd rather have this not warn if the sendchange fails. (i.e. have it set to [('localhost:9011', False)].

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: turn off talos sendchanges to test-masters

good catch.  now with 'False'.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 458448 [details] [diff] [review]
turn off talos sendchanges to test-masters

http://hg.mozilla.org/build/buildbot-configs/rev/577e8b8950e0

Reconfig'd try master at 14:52 PDT. Closing.

Comment 6

[[e-mail] (:bhearsum)]

This didn't do the trick, apparently. Try jobs are still sendchanging to all talos masters.

Comment 7

[Armen [:armenzg]]

I believe it should be something like this (per platform instead of per branch):
BRANCHES['tryserver']['platforms']['macosx64-debug']['talos_masters'] = [('localhost:9011', False)]

Comment 8

[Armen [:armenzg]]

Attachment: stop sending try talos jobs

This worked on staging.
Let me know if you want mozilla/staging_config.py to match mozilla/production_config.py.

Comment 9

[Armen [:armenzg]]

Comment on attachment 460513 [details] [diff] [review]
stop sending try talos jobs

http://hg.mozilla.org/build/buildbot-configs/rev/905b9b693254

pm02:8011 has been reconfigured.

Comment 10

[Armen [:armenzg]]

We are now down from 11 to 5 sendchanges and all 5 are only for unit tests. We are done in here.