579641 - [Collector] Explicit image src on elements in Add-ons Collector makes them hard to style with theme CSS

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[mcdavis941 (sporadically reading bugmail)]

In a few spots, there are images specified as explicit
src on an element (rather than as a list-style-image applied by
CSS).  These are hard to theme because list-style-image from theme CSS is
ignored in that case. You can see the results and why I need to theme
them in the attached screenshot.

Much better from my perspective would be removing src from the image
element in XUL, and instead adding the spinner in Bandwagon CSS with
list-style-image. That way, theme CSS could replace it as needed.

----------------

These are the instances I personally need to be able to theme.  (There are more in Fennec-related source not listed here since I don't work with Fennece.)

add-on_collector-1.1.1\chrome\bandwagon\content\ui\publish.xul(90): <image id="spinner" src="chrome://bandwagon/skin/images/spinner-small.gif" collapsed="true"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\settings.xul(295): <image id="auto-spinner" src="chrome://bandwagon/skin/images/spinner-small.gif" collapsed="true"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\bindings\bandwagon.xml(61): <xul:image anonid="star" src="chrome://bandwagon/skin/images/star.png" style="width: 1em; height: 1em;" collapsed="true"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\bindings\bandwagon.xml(675): <xul:image anonid="thumbnail" class="thumbnail" src="chrome://global/skin/icons/loading_16.png"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(115): <image src="chrome://bandwagon/skin/images/spinner.gif"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(118): <image src="chrome://bandwagon/skin/images/information.png"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(122): <image src="chrome://bandwagon/skin/images/error.png"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(185): <image id="auth-spinner" src="chrome://bandwagon/skin/images/spinner-small.gif" style="visibility: hidden"/>

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Attachment: example of why themes need to be able to replace images

Comment 2

[David McNamara [:mackers]]

Fixed.

r82846

Comment 3

[mcdavis941 (sporadically reading bugmail)]

Looks great, thanks for the fix!