[Collector] Explicit image src on elements in Add-ons Collector makes them hard to style with theme CSS

RESOLVED FIXED in BW-2.0

Status

P2
normal
RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: mcdavis941.bugs, Assigned: kinger)

Tracking

BW-1.1.x
BW-2.0

Details

Attachments

(1 attachment)

In a few spots, there are images specified as explicit
src on an element (rather than as a list-style-image applied by
CSS).  These are hard to theme because list-style-image from theme CSS is
ignored in that case. You can see the results and why I need to theme
them in the attached screenshot.

Much better from my perspective would be removing src from the image
element in XUL, and instead adding the spinner in Bandwagon CSS with
list-style-image. That way, theme CSS could replace it as needed.

----------------

These are the instances I personally need to be able to theme.  (There are more in Fennec-related source not listed here since I don't work with Fennece.)

add-on_collector-1.1.1\chrome\bandwagon\content\ui\publish.xul(90): <image id="spinner" src="chrome://bandwagon/skin/images/spinner-small.gif" collapsed="true"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\settings.xul(295): <image id="auto-spinner" src="chrome://bandwagon/skin/images/spinner-small.gif" collapsed="true"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\bindings\bandwagon.xml(61): <xul:image anonid="star" src="chrome://bandwagon/skin/images/star.png" style="width: 1em; height: 1em;" collapsed="true"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\bindings\bandwagon.xml(675): <xul:image anonid="thumbnail" class="thumbnail" src="chrome://global/skin/icons/loading_16.png"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(115): <image src="chrome://bandwagon/skin/images/spinner.gif"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(118): <image src="chrome://bandwagon/skin/images/information.png"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(122): <image src="chrome://bandwagon/skin/images/error.png"/>
add-on_collector-1.1.1\chrome\bandwagon\content\ui\overlays\extensionsBoxOverlay.xul(185): <image id="auth-spinner" src="chrome://bandwagon/skin/images/spinner-small.gif" style="visibility: hidden"/>
Created attachment 458081 [details]
example of why themes need to be able to replace images
(Assignee)

Updated

9 years ago
Priority: -- → P2
Target Milestone: --- → BW-1.1.2
(Assignee)

Updated

8 years ago
Blocks: 626504
Summary: explicit image src on elements in Add-ons Collector makes them hard to style with theme CSS → [Collector] Explicit image src on elements in Add-ons Collector makes them hard to style with theme CSS
Target Milestone: BW-1.1.2 → BW-2.0
Version: unspecified → BW-1.1.x
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Looks great, thanks for the fix!
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.