Closed Bug 579650 Opened 10 years ago Closed 10 years ago

Missing string in errors.properties

Categories

(Cloud Services :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: fabrice)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

When running Fennec, with Sync built-in, I see a JS error in the console with clean profiles.

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://services-sync/ext/StringBundle.js :: anonymous :: line 134"  data: no]

With some dump output, I see the following error:

Key: error.login.reason.no_username
Bundle URL: chrome://weave/locale/services/errors.properties

(This key doesn't seem to exist in any properties file, although it looks like it _should_ be in errors.properties)
Hmm, odd... looks like we're looking for that string directly, instead of via getErrorString (which wraps the call and returns "Unknown Error" if the string isn't found).  This is so we can add the strings we care about when we need to, without having to add l10n for every single possible error.
I'd like to get this fixed for Fennec a1 or b1. Not sure how that lines up with your releases.

What is the string value?
Flags: blocking-fx-sync1.5?
Duplicate of this bug: 589348
Attached patch fixSplinter Review
This patch doesn't add the missing string, but uses the correct method cited in comment #1 to display the fallback generic error.

The missing error string is error.login.reason.no_username - it should be added to m-c/services/sync/locales/en-US/error.properties
Assignee: nobody → fabrice
Attachment #471155 - Flags: review?
Attachment #471155 - Flags: review? → review?(mconnor)
Comment on attachment 471155 [details] [diff] [review]
fix

I don't expect us to _ever_ hit that error, barring epic failure of a client, so I'd rather not add the string.

r=me on this
Attachment #471155 - Flags: review?(mconnor) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/58a422b67717
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [qa-]
Flags: blocking-fx-sync1.5?
You need to log in before you can comment on or make changes to this bug.