Closed Bug 579686 Opened 13 years ago Closed 13 years ago

StringToInteger not declared before first use in CTypes.cpp

Categories

(Core :: js-ctypes, defect)

Product:
Core
Component:
js-ctypes
Platform:
x86_64
Windows CE
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- beta4+

People

(Reporter: sharparrow1, Assigned: sharparrow1)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Patch
3.00 KB, patch
dwitte
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
Per description; gcc accepts the code because because of bugs in C++ name lookup, but clang doesn't.  See http://clang.llvm.org/compatibility.html#dep_lookup .  Patch simply moves the definition of StringToInteger.
Attachment #458127 - Flags: review?
Attachment #458127 - Flags: review? → review?(dwitte)
Comment on attachment 458127 [details] [diff] [review]
Patch

r=dwitte
Attachment #458127 - Flags: review?(dwitte) → review+
Blocks: clang-macosx
OS: Linux → Windows CE
Assignee: nobody → sharparrow1
blocking2.0: --- → beta4+
I'll land this.
http://hg.mozilla.org/tracemonkey/rev/bdcad897fc94
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/bdcad897fc94
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.