Closed
Bug 579745
Opened 16 years ago
Closed 16 years ago
Prevent default installation of globally installed add-ons
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-1.4.2+])
Attachments
(1 file, 1 obsolete file)
|
1003 bytes,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
In the past we had a lot of problems with globally installed extensions. The most problematic one is definitely Ubufox on Linux. Recently we got other failures because it's not compatible anymore against trunk builds and prevents our software update tests from running correctly.
I think the best solution for our tests is to prevent the installation of global add-ons.
This feature is new in trunk builds of Firefox and can be invoked by simply adding the pref "extensions.enabledScopes=0" to a profile.
Would be great to have in the next beta release of Mozmill 1.4.2. Patch upcoming.
| Assignee | ||
Comment 1•16 years ago
|
||
Attachment #458186 -
Flags: review?(jhammel)
| Assignee | ||
Comment 2•16 years ago
|
||
Please use the alphabetic order for the preferences
Attachment #458187 -
Flags: review?(jhammel)
| Assignee | ||
Updated•16 years ago
|
Attachment #458186 -
Attachment is obsolete: true
Attachment #458186 -
Flags: review?(jhammel)
Comment 3•16 years ago
|
||
Comment on attachment 458187 [details] [diff] [review]
Patch with reordered preferences
Looks fine, though you might want to comment in the python why these preferences were added. In the future, we might think about a few things for default preferences:
Having them in the python is at best questionable for any but the most needed preferences. We pretend to "start with a blank profile", but as per these preferences, its not really true. An .ini file is more editable, e.g. ~/.mozmill/prefs.ini .
Attachment #458187 -
Flags: review?(jhammel) → review+
| Assignee | ||
Comment 4•16 years ago
|
||
Thanks Jeff, I will do it and attach another version of the patch.
Mark, do you also wanna have this default pref set in Mozrunner or is all that stuff not important for you?
| Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #3)
> Having them in the python is at best questionable for any but the most needed
> preferences. We pretend to "start with a blank profile", but as per these
> preferences, its not really true. An .ini file is more editable, e.g.
> ~/.mozmill/prefs.ini .
No. It should be user.js. We can simply drop that file into the profile and all contained preferences will be set.
I will also add comments as proposed.
| Assignee | ||
Comment 6•16 years ago
|
||
Landed on master and 1.4.2:
http://github.com/mozautomation/mozmill/commit/65179c159f0d92e731d7d39a88fa82f8e159cf06
http://github.com/mozautomation/mozmill/commit/fbfeda84c334d212fbbc78b4fe85b36ce98ce9d5
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified using .NET addon under XP
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•