Looking for saved searches? click on "Search Bugs" above.

Not using GTK filechooser anymore

RESOLVED FIXED

Status

Product:
Core Graveyard
Component:
File Handling
--
major
RESOLVED FIXED
Reported:
8 years ago
Modified:
2 years ago

People

(Reporter: micmon, Assigned: Benjamin Smedberg)

Tracking

({regression})

Version:
Trunk
x86
Linux
Keywords:
regression
Duplicates:
579884, 580204

Firefox Tracking Flags

(blocking2.0 beta3+)

Details

Attachments

(2 attachments)

Screenshot
38.50 KB, image/png
Details
nsFilePicker fix
471 bytes, patch
bz
: review+
Details | Diff | Splinter Review
(Reporter)

Description

•
8 years ago 
Created attachment 458200 [details]
Screenshot

In the 20100718 nightly I noticed that the GTK filechooser is not used anymore for save and open operations. I really hope this is a regression and not by design.

Comment 1

•
8 years ago 
Appears to be a regression somehow caused by bug 576991.
Depends on: 576991
Keywords: regression

Updated

•
8 years ago
Blocks: 576991
blocking2.0: --- → ?
Component: Shell Integration → File Handling
No longer depends on: 576991
Product: Firefox → Core
QA Contact: shell.integration → file-handling

Comment 2

•
8 years ago 
Somehow the ui.allow_platform_file_picker not used anymore.
I'll try to find out why.

Comment 3

•
8 years ago 
I think I know what the problem.
 (Reporter)

Updated

•
8 years ago
Duplicate of this bug: 579884
 (Assignee)

Updated

•
8 years ago
Assignee: nobody → benjamin
blocking2.0: ? → beta3+
 (Assignee)

Comment 5

•
8 years ago 
http://hg.mozilla.org/mozilla-central/rev/6575d77caf4f I backed out the nsFilePicker.manifest change from bug 576991 which I'm pretty sure was incorrect.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 6

•
8 years ago 
Created attachment 458578 [details] [diff] [review]
nsFilePicker fix

This is a really stupid mistake. nsFilePicker calls the nsFilePicker.js by CID.
Attachment #458578 - Flags: review?(bzbarsky)

Comment 7

•
8 years ago 
(In reply to comment #5)
> http://hg.mozilla.org/mozilla-central/rev/6575d77caf4f I backed out the
> nsFilePicker.manifest change from bug 576991 which I'm pretty sure was
> incorrect.

Yes. I'm sorry. But other changes are correct.

Comment 8

•
8 years ago 
Comment on attachment 458578 [details] [diff] [review]
nsFilePicker fix

r=me, but Benjamin checked this in already.
Attachment #458578 - Flags: review?(bzbarsky) → review+
Duplicate of this bug: 580204

Comment 10

•
8 years ago 
I thought the XUL filepicker was only built on GTK builds anyway?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.