warning: deprecated conversion from string constant to 'char*' in nsPop3Protocol

ASSIGNED
Assigned to

Status

ASSIGNED
8 years ago
5 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patchlove])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
mailnews/local/src/nsPop3Protocol.cpp:
 In member function ‘PRInt32 nsPop3Protocol::GetXtndXlstMsgid(nsIInputStream*, PRUint32)’:
2678: warning: deprecated conversion from string constant to ‘char*’
 In member function ‘PRInt32 nsPop3Protocol::GetUidlList(nsIInputStream*, PRUint32)’:
2793: warning: deprecated conversion from string constant to ‘char*’
(Assignee)

Comment 1

8 years ago
Created attachment 458224 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #458224 - Flags: review?(bienvenu)

Comment 2

8 years ago
Comment on attachment 458224 [details] [diff] [review]
patch

this leaves m_pop3ConData->msg_info[i].uidl as null instead of pointing to an empty string which is treated differently in the code. I don't know that it would cause problems, or if this error actually happens in the wild any more, but I'd hate for a warning fix to cause a regression.
Attachment #458224 - Flags: review?(bienvenu) → review-

Updated

5 years ago
Whiteboard: [patchlove]
You need to log in before you can comment on or make changes to this bug.