warning: comparison between signed and unsigned integer expressions in nsMsgDatabase

RESOLVED WORKSFORME

Status

MailNews Core
Database
RESOLVED WORKSFORME
8 years ago
4 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
mailnews/db/msgdb/src/nsMsgDatabase.cpp:
 In member function ‘virtual nsresult nsMsgDBService::OpenMore(nsIMsgDatabase*, PRInt32, PRBool*)’:
287: warning: comparison between signed and unsigned integer expressions
 In member function ‘void nsMsgDatabase::ClearEnumerators()’:
563: warning: comparison between signed and unsigned integer expressions
 In member function ‘virtual nsresult nsMsgDatabase::DeleteHeader(nsIMsgDBHdr*, nsIDBChangeListener*, PRBool, PRBool)’:
1916: warning: comparison between signed and unsigned integer expressions
 In member function ‘virtual PRUint32 nsMsgDatabase::GetStatusFlags(nsIMsgDBHdr*, PRUint32)’:
2030: warning: comparison between signed and unsigned integer expressions
(Assignee)

Comment 1

8 years ago
Created attachment 458267 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #458267 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #458267 - Flags: review? → review?(bienvenu)

Comment 2

7 years ago
Comment on attachment 458267 [details] [diff] [review]
patch

I still see a couple warnings with the patch applied.
Attachment #458267 - Flags: review?(bienvenu) → review-

Comment 3

5 years ago
I do not see these warnings on Linux. Is this really Mac OS X only? Is timeless still working on this?
Flags: needinfo?(timeless)
Whiteboard: [CLOSEME-2013-02-01]

Comment 4

5 years ago
Resolved per whiteboard
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [CLOSEME-2013-02-01]
(Assignee)

Updated

4 years ago
Flags: needinfo?(timeless)
Resolution: INCOMPLETE → WORKSFORME
You need to log in before you can comment on or make changes to this bug.