Closed
Bug 579838
Opened 14 years ago
Closed 14 years ago
remove assert in gfxFontUtils::FindPreferredSubtable
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: jtd, Unassigned)
Details
Attachments
(1 file)
|
994 bytes,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
The assertion in gfxFontUtils::FindPreferredSubtable is not necessary: http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFontUtils.cpp#543 If the cmap table contains a bad offset we should just return an error, not assert. The NS_ENSURE_TRUE on the following lines does that.
Attachment #458274 -
Flags: review?(jfkthame)
|
||
Updated•14 years ago
|
Attachment #458274 -
Flags: review?(jfkthame) → review+
|
Reporter | |
Comment 1•14 years ago
|
||
Pushed to trunk http://hg.mozilla.org/mozilla-central/rev/6b58d2615145
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•