579842 - warning: comparison between signed and unsigned integer expressions in nsMsgDBView

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[timeless]

mailnews/base/src/nsMsgDBView.cpp:
 In member function ‘nsresult nsMsgDBView::GetSelectedIndices(nsMsgViewIndexArray&)’:
1184: warning: comparison between signed and unsigned integer expressions
 In member function ‘virtual nsresult nsMsgDBView::ApplyCommandToIndices(nsMsgViewCommandTypeValue, nsMsgViewIndex*, PRInt32)’:
2787: warning: comparison between signed and unsigned integer expressions
2858: warning: unused variable ‘isRead’
 In member function ‘virtual nsresult nsMsgDBView::DeleteMessages(nsIMsgWindow*, nsMsgViewIndex*, PRInt32, PRBool)’:
2960: warning: comparison between signed and unsigned integer expressions
 In member function ‘nsresult nsMsgDBView::SetMsgHdrJunkStatus(nsIJunkMailPlugin*, nsIMsgDBHdr*, nsMsgJunkStatus)’:
3206: warning: enumeral mismatch in conditional expression: ‘nsIJunkMailPlugin::<anonymous enum>’ vs ‘nsIJunkMailPlugin::<anonymous enum>’
 In member function ‘nsresult nsMsgDBView::PerformActionsOnJunkMsgs(PRBool)’:
3341: warning: comparison between signed and unsigned integer expressions
 In member function ‘nsMsgViewIndex nsMsgDBView::GetIndexForThread(nsIMsgDBHdr*)’:
4941: warning: comparison between signed and unsigned integer expressions
 In member function ‘nsMsgViewIndex nsMsgDBView::GetThreadRootIndex(nsIMsgDBHdr*)’:
5470: warning: comparison between signed and unsigned integer expressions
 In member function ‘virtual nsresult nsMsgDBView::GetMsgToSelectAfterDelete(nsMsgViewIndex*)’:
6797: warning: comparison between signed and unsigned integer expressions
 In member function ‘virtual nsresult nsMsgDBView::nsMsgViewHdrEnumerator::GetNext(nsISupports**)’:
7364: warning: comparison between signed and unsigned integer expressions
 In member function ‘virtual nsresult nsMsgDBView::nsMsgViewHdrEnumerator::HasMoreElements(PRBool*)’:
7382: warning: comparison between signed and unsigned integer expressions

2858/isRead is actually an unused variable, but call it collateral damage :)

Comment 1

[timeless]

Attachment: patch

Comment 2

[David :Bienvenu]

Comment on attachment 458275 [details] [diff] [review]
patch

-      while (lowIndex < GetSize() && m_levels[lowIndex])
+      while (lowIndex < GetSize() &&
+             m_levels[lowIndex])
         lowIndex++;

I don't see any reason to make these lines any shorter; they're already less than 80 chars. I need to look more closely at some of the other changes...

Comment 3

[David :Bienvenu]

Attachment: unbit-rotted, and addressing my own comments.

I'll land this, once I check that it doesn't regress any of the unit tests...

Comment 4

[David :Bienvenu]

fix checked in, thx for the patch.